Fix ListDialogItem click causing hyperlinks to be clicked twice

ethanmoffat · Apr 6, 2022 · dc51324 · dc51324
1 parent 722530a
commit dc51324
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/EndlessClient/Dialogs/ListDialogItem.cs b/EndlessClient/Dialogs/ListDialogItem.cs
@@ -223,10 +223,8 @@ protected override void OnUpdateControl(GameTime gameTime)
                 else if(CurrentMouseState.LeftButton == ButtonState.Released &&
                         PreviousMouseState.LeftButton == ButtonState.Pressed)
                 {
-                    // todo: this might cause the click event to be fired twice, need to double check it
-                    if (_subText is XNAHyperLink && _subText.MouseOver)
-                        ((XNAHyperLink)_subText).Click();
-                    else
+                    if ((_subText is IXNAHyperLink && !_subText.MouseOver) ||
+                        (_primaryText is IXNAHyperLink && !_primaryText.MouseOver))
                         LeftClick?.Invoke(this, EventArgs.Empty);
 
                     _parentList.ChildControlClickHandled = true;