-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+ onLoad prop for images #14
Conversation
Hi @sk1e - This looks great! I think your PR introduces useful features. I'm wondering how comfortable you are with documenting the new features on readme.md. Please let me know. I opened a PR to your fork with a suggested change. Please have a look. |
@ethanselzer I'm glad you find it useful. I'll resolve your suggestions shortly. |
Refactor onLoad
@ethanselzer Not sure how to specify a type for the function: just |
@sk1e - Very nice! I want to thank you again for your contribution. If you find react-image-magnify useful, please consider starring it on GitHub. Starring helps to grow the project, which benefits everyone. |
Please see release notes |
@ethanselzer it's been nice working with you. Cheers :) |
@sk1e - It has been great working with you also. Thanks again! |
Hi, adding optional onLoad prop for small and large images.