Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ onLoad prop for images #14

Merged
merged 6 commits into from
Oct 19, 2017
Merged

Conversation

sk1e
Copy link
Contributor

@sk1e sk1e commented Oct 16, 2017

Hi, adding optional onLoad prop for small and large images.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 97.619% when pulling 77d0906 on sk1e:add-onload-props into e07f632 on ethanselzer:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 98.81% when pulling a97cf52 on sk1e:add-onload-props into e07f632 on ethanselzer:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69180b5 on sk1e:add-onload-props into e07f632 on ethanselzer:master.

@ethanselzer
Copy link
Owner

ethanselzer commented Oct 17, 2017

Hi @sk1e - This looks great! I think your PR introduces useful features. I'm wondering how comfortable you are with documenting the new features on readme.md. Please let me know. I opened a PR to your fork with a suggested change. Please have a look.

@sk1e
Copy link
Contributor Author

sk1e commented Oct 18, 2017

@ethanselzer I'm glad you find it useful. I'll resolve your suggestions shortly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4c658ac on sk1e:add-onload-props into e07f632 on ethanselzer:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 22da99b on sk1e:add-onload-props into e07f632 on ethanselzer:master.

@sk1e
Copy link
Contributor Author

sk1e commented Oct 18, 2017

@ethanselzer Not sure how to specify a type for the function: just Function or maybe it would be better to show its range and domain in typescript notation — () => void or both — Function (() => void). I would prefer the last one since I think that signatures are important and it keeps your documentation style.

@ethanselzer
Copy link
Owner

@sk1e - Very nice! I want to thank you again for your contribution. If you find react-image-magnify useful, please consider starring it on GitHub. Starring helps to grow the project, which benefits everyone.

@ethanselzer ethanselzer merged commit 0dd1e8c into ethanselzer:master Oct 19, 2017
@ethanselzer
Copy link
Owner

Please see release notes

@sk1e
Copy link
Contributor Author

sk1e commented Oct 19, 2017

@ethanselzer it's been nice working with you. Cheers :)

@ethanselzer
Copy link
Owner

ethanselzer commented Oct 19, 2017

@sk1e - It has been great working with you also. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants