Skip to content

Commit

Permalink
add code
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanvc committed Jan 12, 2024
1 parent 49ecb08 commit 06d654b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion evohttp/log_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func (h *LogHandler) Handle(c context.Context, req any, info *RequestInfo, nexte
TraceId: info.Request.Header.Get("x-trace-id"),
})
resp, err = nexter.Next(c, req, info)
h.logger().Log(c, err, info.ParsedRequest, resp,
h.logger().LogWithSkip(c, 0, err, info.ParsedRequest, resp,
slog.Int("http_code", info.Writer.GetStatus()),
slog.String("path", info.Request.URL.Path),
)
Expand Down
6 changes: 1 addition & 5 deletions httpcli/single_attempt.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,7 @@ func (template *HttpTemplate) report(err error, sa *SingleAttempt, req, resp any
template.Report(err, sa, req, resp)
return
}
plog.DefaultRequestLogger().Log(sa.Request.Context(), &plog.RequestLogInfo{
Err: err,
Req: req,
Resp: resp,
}, slog.String("code", http.StatusText(sa.GetResponseCode())))
plog.DefaultRequestLogger().Log(sa.Request.Context(), err, req, resp, slog.String("code", http.StatusText(sa.GetResponseCode())))
}

func (template *HttpTemplate) realDo(req, resp any, sa *SingleAttempt) (err error) {
Expand Down
8 changes: 6 additions & 2 deletions plog/request_logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ func NewRequestLogger(
}

func (rl *RequestLogger) Log(c context.Context, err error, req, resp any, extra ...any) {
rl.LogWithSkip(c, 1, err, req, resp, extra...)
}

func (rl *RequestLogger) LogWithSkip(c context.Context, skip int, err error, req, resp any, extra ...any) {
s := base.Convert(err)
DefaultReporter().ReportRequest(c, s.GetCode(), s.GetEvent())
lvl := rl.callFilter(c, err, req, resp)
Expand All @@ -51,7 +55,7 @@ func (rl *RequestLogger) Log(c context.Context, err error, req, resp any, extra
if events := lc.GetEvents(); len(events) > 0 {
args = append(args, slog.String("events", events))
}
Log(c, lvl, 1, "REQ_END", args...)
Log(c, lvl, skip+1, "REQ_END", args...)
}

func (rl *RequestLogger) callFilter(c context.Context, err error, req, resp any) slog.Level {
Expand Down Expand Up @@ -108,5 +112,5 @@ func DefaultFilter(c context.Context, err error, req, resp any) slog.Level {
}

func RequestLog(c context.Context, err error, req, resp any, extra ...any) {
DefaultRequestLogger().Log(c, err, req, resp, extra...)
DefaultRequestLogger().LogWithSkip(c, 1, err, req, resp, extra...)
}

0 comments on commit 06d654b

Please sign in to comment.