Feature suggestion: Display comments as icons on right margin

[lpagliari]

On the Etherpad instance we're using, we need another way to display comments. I don't know if it would be useful for ep_comments to have it incorporated to the code, or if we should implement it on a separated plugin (or a fork of this one). Let me know if you think this is something nice to have here, and I'll submit a PR.

Here are the details about it:

• Instead of displaying boxes on the right side of the screen, there would be icons on the right margin of the page:

  

• Comment details would be displayed only when I click on the icon:

  

• Clicking again on the icon would close comment details;

• Comments with replies would have a different icon (the actual icon I was thinking is this one, but I could not find it quickly on Etherpad, so I used the ones I found for this spike):

  

• When there are 2+ comments on the same line, each comment would have its own icon, side-by-side:

  

• One thing that we can do is create a toggle to allow user to choose whether to display comments as icons or as it is right now.

Let me know your thoughts.

[JohnMcLear]

Do it in the main branch but put it under a server side setting called "onlyShowCommentIcon" or something :). Its a good suggestion BTW as it keeps the ui clean

[lpagliari]

Awesome, thanks!

[JohnMcLear]

Quick question, does this introduce another http request?

[lpagliari]

Nope, it just handles what comes on the inner pad (the comment ids), in a
very similar way of what is done with sidebar comments.

On Thursday, June 11, 2015, John McLear notifications@github.com wrote:

Quick question, does this introduce another http request?

—
Reply to this email directly or view it on GitHub
#36 (comment)
.

[JohnMcLear]

I put this live on https://beta.etherpad.org/p/HAKOOKy48b so it gets some testing..

Some thing I noticed..

1. It looks kinda bad when page view isn't on

2. Icons don't look right still?

[lpagliari]

Still working on that. I finished my fixes for the icons when PV is off some minutes ago, but had to rebase and now I'm checking if something is broken after the last 30+ commits we had on the last few days. :)

[JohnMcLear]

Yeah sorry about that.. I'm done now =)

[lpagliari]

no, no, it was awesome!! Great features, I loved it

[lpagliari]

ok, submitted PR #57 now.

[JohnMcLear]

Updated beta.etherpad.org still getting that issue. Maybe it should be forcing page view on too?

[lpagliari]

Hum, it looks fine for me when PV is off:

[JohnMcLear]

Note the weird symbol next to the comments icon..

[lpagliari]

This is the icon I added to Etherpad code a few days ago. Is beta.etherpad.org using the develop branch?

[JohnMcLear]

blah good point I don't think I pulled the repo, sec..

[JohnMcLear]

There ya go, looking sexy!

Good job!

[lpagliari]

:)