Adding pads doesn't work in Etherpad 1.5.5 on Windows

[shaker]

Hello.

I have a problem with Etherpad 1.5.5 on Windows. I unpacked the files to a clean folder (I got the archive from http://etherpad.org/downloads/etherpad-lite-win-1.5.5-24b0712d77.zip).

1. Run "start.bat".
2. Go to localhost:9001
3. Enter some text on textbox and then press "OK".
4. An error occured while loading the pad. ReferenceError: require is not defined in http://localhost:9009/p/123 (line 531)

Console:

GET http://localhost:9009/static/js/require-kernel.js HTTP/1.1 404 Not Found
ReferenceError: require is not defined http://localhost:9009/javascripts/lib/ep_etherpad-lite/static/js/pad.js?callback=require.define
ReferenceError: require is not defined http://localhost:9009/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define
ReferenceError: require is not defined dddddd:531:14 require.setRootURI(baseURL + "javascripts/src");

I've tried in WinXP, Win7, Firefox and Chome. File require-kernel.js doesn't exist in the folder with static files. I'm not good in Javascript or Node (and English, sorry).
I have successfully used the version 1.2.7 before.

[JohnMcLear]

What version of node? Have you tried a
clean install?

----- Reply message -----
From: "Kolchanskiy Dmitriy" notifications@github.com
To: "ether/etherpad-lite" etherpad-lite@noreply.github.com
Subject: [etherpad-lite] Adding pads doesn't work in Etherpad 1.5.5 on Windows (#2614)
Date: Wed, Apr 15, 2015 13:30

Hello.

I have a problem with Etherpad 1.5.5 on Windows. I unpacked the files to a clean folder (I got the archive from http://etherpad.org/downloads/etherpad-lite-win-1.5.5-24b0712d77.zip).

1. Run "start.bat".
2. Go to localhost:9001
3. Enter some text on textbox and then press "OK".
4. An error occured while loading the pad. ReferenceError: require is not defined in http://localhost:9009/p/123 (line 531)

Console:

GET http://localhost:9009/static/js/require-kernel.js HTTP/1.1 404 Not Found
ReferenceError: require is not defined http://localhost:9009/javascripts/lib/ep_etherpad-lite/static/js/pad.js?callback=require.define
ReferenceError: require is not defined http://localhost:9009/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define
ReferenceError: require is not defined dddddd:531:14 require.setRootURI(baseURL + "javascripts/src");

I've tried in WinXP, Win7, Firefox and Chome. File require-kernel.js doesn't exist in the folder with static files. I'm not good in Javascript or Node (and English, sorry).
I have successfully used the version 1.2.7 before.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2614.

[shaker]

Standalone Node is in the archive etherpad-lite-win-1.5.5-24b0712d77.zip and has version 0.10.38.
Have I tried a clean install of Node or Etherpad? Etherpad - I've tried (as actually in the message above), Node - I haven't.

[JohnMcLear]

Try download again, extract again and see if it works.. Node 10 should be okay..

[JohnMcLear]

I did notice during extraction with native windows extractor on w8 we have some issues with path being too long, I thought I'd resolved that..

[JohnMcLear]

afaik https://github.com/ether/etherpad-lite/blob/develop/bin/buildForWindows.sh#L59 is no longer needed..

[JohnMcLear]

I'm able to replicate this issue on 1.5.5

[JohnMcLear]

The issue exists on a fully extracted version of Etherpad. Ugh

[JohnMcLear]

This will be a bit of a pain in the ass to debug... It will be quicker for you to bring up a linux VM and run it in there while we fix it up.

[JohnMcLear]

1.5.1 is fine, as is 1.5.2

[JohnMcLear]

1.5.3 is broken, doing bisect now to find commit.

[shaker]

I don't mind the wait. :-) An older 1.2.7 version of Etherpad works well.

[JohnMcLear]

Breaking commit

9d4e5f6 is the first bad commit
commit 9d4e5f6
Author: John McLear john@mclear.co.uk
Date: Fri Apr 10 22:02:22 2015 +0100

dont allow directory traversal

:040000 040000 7e28e7ab56134df08cc8d96f5f0b660ec05149b3 536e5baec42fecf77bf691a1
a2ee25c0851ed362 M src

[JohnMcLear]

@devoidfury any suggestion for how to best handle this?

[JohnMcLear]

Thanks for the fix @devoidfury -- works 10/10 ! :)

[JohnMcLear]

@Gared we might want to do another release due to this?

[devoidfury]

No problem, sorry about the regression!

[Gared]

@JohnMcLear Do we really want to release again? Maybe we should wait until @Pita is done with his iframe removal process?!
Btw: you can grab latest windows build here: http://stefans-entwicklerecke.de/wp-content/eplite-nightly-builds/

[JohnMcLear]

Oh we wont be merging in the iframe stuff for at least 3 months!

I don't think releasing again will hurt, not releasing will..

[shaker]

Thanks guys!
Nightly-build works well.

[JohnMcLear]

+1 shaker tnx

[Gared]

@JohnMcLear If you want I can do another release for this. Probably I can do it today evening.

[JohnMcLear]

Perfect thanks :)