Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker install instructions to readme. #3623

Closed
dessalines opened this issue Jul 5, 2019 · 1 comment
Closed

Add docker install instructions to readme. #3623

dessalines opened this issue Jul 5, 2019 · 1 comment
Labels
docker

Comments

@dessalines
Copy link

There are no instructions on how to do a docker install on the README.
@muxator
Copy link
Contributor

muxator commented Jul 11, 2019

Hi @dessalines, personally I think this is a bit out of scope: an advanced user would know how to do it, while a newcomer would blindly copy the (soon outdated) instructions without understanding them.

But then, maybe you are right and a short section with the instructions (maybe with an external link for who wants more information) could be useful.

Feel free to propose a change and let's see.

pierreprinetti added a commit to pierreprinetti/etherpad that referenced this issue Oct 1, 2019
@pierreprinetti
docker: Enable env var settings by default
e37c054 
By leveraging the templating mechanism in `settings.json`, this change
allows a Docker client to run a prebuilt image and change some basic
configuration settings, like the instance name or, more importantly, the
database coordinates.

Also addresses ether#3623
@pierreprinetti pierreprinetti mentioned this issue Oct 1, 2019
Merged
muxator pushed a commit to pierreprinetti/etherpad that referenced this issue Oct 18, 2019
@pierreprinetti
docker: Enable env var settings by default
c8287a3 
By leveraging the templating mechanism in `settings.json`, this change
allows a Docker client to run a prebuilt image and change some basic
configuration settings, like the instance name or, more importantly, the
database coordinates.

Also addresses ether#3623
muxator pushed a commit to pierreprinetti/etherpad that referenced this issue Oct 18, 2019
@pierreprinetti
docker: Enable env var settings by default
b4ee08b 
By leveraging the templating mechanism in `settings.json`, this change
allows a Docker client to run a prebuilt image and change some basic
configuration settings, like the instance name or, more importantly, the
database coordinates.

Also addresses ether#3623
muxator pushed a commit to pierreprinetti/etherpad that referenced this issue Oct 19, 2019
@pierreprinetti
docker: Enable env var settings by default
1e57cf0 
By leveraging the templating mechanism in `settings.json`, this change
allows a Docker client to run a prebuilt image and change some basic
configuration settings, like the instance name or, more importantly, the
database coordinates.

Also addresses ether#3623
@muxator muxator added the docker label Oct 19, 2019
muxator pushed a commit to pierreprinetti/etherpad that referenced this issue Oct 19, 2019
@pierreprinetti
docker: enable environment variables settings by default
8070959 
By leveraging the templating mechanism in `settings.json`, this change allows a
Docker client to run a prebuilt image and change some basic configuration
settings, like the instance name or, more importantly, the database
coordinates.

By default, the image runs witho no administrative user enabled. If a value is
given to ADMIN_PASSWORD, the `admin` user will be activated.

Also closes ether#3623

---
Modified by muxator to support conditional user activation at runtime.
muxator pushed a commit to pierreprinetti/etherpad that referenced this issue Oct 19, 2019
@pierreprinetti
docker: enable environment variables settings by default
2ee47e2 
By leveraging the templating mechanism in `settings.json`, this change allows a
Docker client to run a prebuilt image and change some basic configuration
settings, like the instance name or, more importantly, the database
coordinates.

By default, the image runs witho no administrative user enabled. If a value is
given to ADMIN_PASSWORD, the `admin` user will be activated.

Also closes ether#3623

---
Modified by muxator to support conditional user activation at runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dessalines @muxator