Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.8.3: what do we want to include? #3781

Closed
muxator opened this issue Mar 29, 2020 · 7 comments
Closed

Release 1.8.3: what do we want to include? #3781

muxator opened this issue Mar 29, 2020 · 7 comments
Labels

Comments

@muxator
Copy link
Contributor

muxator commented Mar 29, 2020

We have done a lot of work lately, thanks to @JohnMcLear that came back with all his energy (many thanks, John).

It is time to start thinking about a release.

There are still a lot of PRs & issues outstanding, and before we cut a new release, we need to select what to include and what to leave behind.

My proposal is:

Let's review the milestone for 1.8.1 and include there all the PRs / issues that we want to integrate, and move to 1.8.2 everything that we decide to leave out.

@JohnMcLear
Copy link
Member

@JohnMcLear
Copy link
Member

JohnMcLear commented Apr 6, 2020

I think we should include #3833
and
#3827

As they both address security issues.

Also did we rename 1.8.1 > 1.8.3 for some reason? :D

@JohnMcLear JohnMcLear added this to the 1.8.3 milestone Apr 6, 2020
@muxator
Copy link
Contributor Author

muxator commented Apr 7, 2020

Also did we rename 1.8.1 > 1.8.3 for some reason? :D

Yep. 1.8.3 was the version that programmed to dump nodejs 8 support. Sticking to that.

@muxator muxator changed the title Release 1.8.1: what do we want to include? Release 1.8.3: what do we want to include? Apr 8, 2020
@micah
Copy link
Contributor

micah commented Apr 18, 2020

Is it possible to have a release that only fixes the critical, security bugs, and doesn't do the entire nodejs migration? The reason I ask is because those fixes seem important to get out there quickly, and combining those with the nodejs migration will make it harder for us to deploy the new version.

Thanks!

@JohnMcLear
Copy link
Member

What do you mean by "entire nodejs migration"? :D

@muxator
Copy link
Contributor Author

muxator commented Apr 19, 2020

@micah, starting from 2020, nodejs 8 is not supported by its developer (https://nodejs.org/en/about/releases/). The deprecation has been in the roadmap for quite a long time.

Moving to a different node version is really easy, if you are ok using the binary release from https://nodejs.org/en/download/ instead of your distro's.

It's really unzipping a tarball and putting a symlink to node and npm in your process's path. It does not even need to be done on the system level.

@muxator
Copy link
Contributor Author

muxator commented Apr 21, 2020

Closing this ticket. The missing items for the release are being tracked in the 1.8.3 milestone.

@muxator muxator closed this as completed Apr 21, 2020
@muxator muxator removed this from the 1.8.3 milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants