Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed Headings plugin to default EtherPad install #4730

Closed
ZDVokoun opened this issue Feb 8, 2021 · 2 comments · Fixed by #4826
Closed

Embed Headings plugin to default EtherPad install #4730

ZDVokoun opened this issue Feb 8, 2021 · 2 comments · Fixed by #4826
Assignees
@JohnMcLear
Labels
Feature Request

Comments

@ZDVokoun
Copy link

ZDVokoun commented Feb 8, 2021

name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees:

Is your feature request related to a problem? Please describe.
Lots of public instances of EtherPad don't have the headings plugin installed, although heading are used in majority of documents. This can be a problem for someone, including me.

Describe the solution you'd like
Either build headings plugin into EtherPad or automatically install headings plugin on install.

Describe alternatives you've considered
Contact admins of public instances and ask them to install the plugin.

Additional context

Plugin?
@JohnMcLear
Copy link
Member

JohnMcLear commented Feb 8, 2021 •
edited

I think we can re-frame this question and provide a mechanism to notify admins if a user expects for a plugin to be supported.

My proposal is that upon import if an attribute is detected that isn't supported IE heading:1 then there is a console.warn message for the sysadmin to see IE

A user tried to import a pad that had the attribute heading:1 but your server does not support this property. Please install the plugin that supports this attribute.

@JohnMcLear JohnMcLear self-assigned this Feb 11, 2021
JohnMcLear added a commit that referenced this issue Feb 19, 2021
@JohnMcLear
pluginfw: Warn plugins on missing plugin
5d6cde8 
Add functionality to console.warn when a plugin is missing.  This will help admins know when people are trying to use plugins that are missing.  Resolves #4730
@JohnMcLear JohnMcLear mentioned this issue Feb 19, 2021
Merged
@JohnMcLear
Copy link
Member

JohnMcLear commented Feb 19, 2021 •
edited

Ready for review/testing.

JohnMcLear added a commit that referenced this issue Feb 21, 2021
@JohnMcLear
pluginfw: Warn plugins on missing plugin (#4826)
ee2b322 
* pluginfw: Warn plugins on missing plugin

Add functionality to console.warn when a plugin is missing.  This will help admins know when people are trying to use plugins that are missing.  Resolves #4730

* pluginfw: importing .etherpad can notify admins of missing plugins

Extending .etherpad imports to notify admins if a missing plugin is present

* Update ImportEtherpad.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnMcLear JohnMcLear

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pluginfw: Warn plugins on missing plugin ether/etherpad-lite
2 participants
@JohnMcLear @ZDVokoun