Check pad deltas - Ready for Review / Merge @muxator #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ether#3717 (comment) > Afaik I used async / await that's pretty much all, I think I had to do some > polish because something was broken, remember stuff like pad.getPadAuthors was > b0rked in 1.7 or so
|
Mheh I didn't rebase but I'm pretty sure the showChat stuff is good to merge so all good to just use this. |
Updating
|
So this PR just need to add |
muxator
force-pushed
the
checkPadDeltas
branch
2 times, most recently
from
c9e81ca
to
0d3e825
Compare
|
So I went ahead and downloaded Marcel's original version from the url you mentioned, and then put yours on top. This results in the following diff, which is difficult to understand: 0d3e825 Could you explain it? From the initial comment i thought it was similar or equal to the file you linked, but there are many differences. Any pointers? Thanks |
|
Afaik I used async / await that's pretty much all, I think I had to do some polish because something was broken, remember stuff like pad.getPadAuthors was b0rked in 1.7 or so |
JohnMcLear
changed the title
Committed by muxator on 2020-03-22, taking the raw version from: https://gist.githubusercontent.com/marcelklehr/a78d293571e7f06e3cf9/raw/c65b496402a752fbf746ab7d3736381b9b084da4/checkPadDeltas.js
muxator
pushed a commit
to JohnMcLear/etherpad-lite
that referenced
this pull request
Mar 27, 2020
From ether#3717 (comment) > Afaik I used async / await that's pretty much all, I think I had to do some > polish because something was broken, remember stuff like pad.getPadAuthors was > b0rked in 1.7 or so
muxator
pushed a commit
to JohnMcLear/etherpad-lite
that referenced
this pull request
Mar 27, 2020
From ether#3717 (comment) > Afaik I used async / await that's pretty much all, I think I had to do some > polish because something was broken, remember stuff like pad.getPadAuthors was > b0rked in 1.7 or so Fixes ether#2107.
muxator
force-pushed
the
checkPadDeltas
branch
2 times, most recently
from
564297b
to
d2aa265
Compare
|
Pulled in, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://gist.github.com/marcelklehr/a78d293571e7f06e3cf9
Requested in #2107