Fix clear cookies tests #3775
Merged
Fix clear cookies tests #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in 2012 with cd368b5.
|
+1 looks good |
muxator
force-pushed
the
fix-clear-cookies-tests
branch
from
1cb9ff3
to
4c281f9
Compare
|
This was not scheduled for 1.8.4 (which should only be a release for the regressions introduced in 1.8.3), but is not a change to the core, and is long overdue. Keeping & merging, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned in #3730 that I thought that there needed to be a delay between resetting the cookies and returning from
newPad, because the change wasn't taking effect otherwise. However, this test proves that incorrect, at least almost all of the time. Seemingly on rare occasion, it fails, which means either:a) occasionally it does indeed need the delay
b) something else entirely is going on
When I have a bit more time, I can try to test it with and without the delay enough times to prove that the delay actually fixes it. But it's quite a rare occurrence so I'm not sure how to be sure about it. Alternately: it's so rare that it's fine, given that this is a test suite; this question is up to the reviewers.