Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: formdidable 3.1.3 - requires node 13 or hack. #5759

Closed
wants to merge 3 commits into from
Closed

Conversation

JohnMcLear
Copy link
Member

No description provided.

@JohnMcLear
Copy link
Member Author

  1) D:\a\etherpad-lite\etherpad-lite\src\tests\backend\specs\api\api.js
       can obtain API version:
     Error: expected 200 "OK", got 404 "Not Found"
      at Context.<anonymous> (tests\backend\specs\api\api.js:37:10)
      at processImmediate (internal/timers.js:464:21)

@JohnMcLear
Copy link
Member Author

[2023-06-24 09:50:35.477] [ERROR] console - Failed to load hook function "/home/jose/etherpad-lite/node_modules/ep_etherpad-lite/node/hooks/express/openapi:expressPreSession" for plugin "ep_etherpad-lite" part "openapi" hook set "hooks" hook "expressPreSession": Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/jose/etherpad-lite/src/node_modules/formidable/src/index.js
require() of ES modules is not supported.

@JohnMcLear
Copy link
Member Author

JohnMcLear commented Jun 24, 2023

Instead rename index.js to end in .cjs, 
change the requiring code to use import(), 
or remove "type": "module" from 
/home/jose/etherpad-lite/src/node_modules/formidable/package.json.

@JohnMcLear
Copy link
Member Author

We can address this when we bump to node13 as requirement.

12 is not enough

@JohnMcLear JohnMcLear changed the title deps: formdidable 3.1.3 deps: formdidable 3.1.3 - requires node 13 or hack. Jun 24, 2023
@SamTV12345
Copy link
Member

Don't we have Node 14 in your package.json as a requirement?

@JohnMcLear
Copy link
Member Author

Don't we have Node 14 in your package.json as a requirement?

I think so ergo I must be incorrect.

@JohnMcLear JohnMcLear marked this pull request as draft June 27, 2023 13:09
@SamTV12345
Copy link
Member

Closing as this was merged in another pr.

@SamTV12345 SamTV12345 closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants