Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating npm #5812

Closed
wants to merge 31 commits into from
Closed

Updating npm #5812

wants to merge 31 commits into from

Commits on Dec 18, 2023

  1. Use npm link to install ep_etherpad-lite. This places a package.json

    file in the root directory that references ./src directory as the file
    source for `ep_etherpad-lite`.
    
    Remove --legacy-peer-deps and --no-save when invoking npm. There is no
    need for them anymore, as we are bumping npm now to v8.
    
    ./src/package.json contains all dependencies of Etherpad core
    (package name ep_etherpad-lite) as before. The root directory's
    package.json file references ep_etherpad-lite and also contains
    references to any installed plugins.
    
    Remove npm from package.json as we depend on a recent version now; PATH is still updated as before, so in the future we may install a custom npm version again
    
    lint package-lock: update exception for sqlite3
    
    remove node_modules and package.json during installDeps.sh
    
    update Dockerfile
    
    adapt minify
    
    windows build
    
    Fixed installOnWindows.bat
    
    remove node_modules from git
    
    bump minimal node/npm version in src/bin/functions.sh
    
    add changelog notes
    
    update installdeps
    
    fix dockerfile
    
    docker: test npm prefix set to the etherpad directory
    
    workflow: upgrade-from-latest-release needs to be adapted until next release is out
    
    Revert "docker: test npm prefix set to the etherpad directory"
    
    This reverts commit b856a24.
    
    use npm link --bin-links=false to prevent it from copying bin files
    
    temp fix for scripts as they are not installed to bin directory anymore
    
    adjust bin paths in Dockerfile
    
    Dockerfile
    
    add hint for npm link, dockerfile
    
    update dockerfile
    
    Revert "Fixed installOnWindows.bat"
    
    This reverts commit 70d0716.
    
    try installOnWindows; still TODO: no difference between production and development; no warning like in installDeps.sh before update - it just removes package* and node_modules so admins must be aware of the plugins they want to reinstall later
    
    update installOnWindows.bat
    
    update package-lock.json
    
    Dockerfile
    
    Dockerfile
    
    add file: scheme for lint check - needed as long as we have the plugin compatibility symlinks in ./src/node_modules
    
    fix installOnWindows
    
    upgrade-from-latest-release workflow: adapt cypress installation
    
    src/package.json: test-container fix path to _mocha; maybe revert this in case we enable bin-links again
    
    src/package.json: add test-on-windows script
    
    another try with test-on-windows, without using bin-links
    
    use bin-links on windows
    
    Revert "use bin-links on windows"
    
    This reverts commit f50ec2a.
    
    invoke mocha binary on windows
    
    run npm i once on windows, to make bin files available - why?
    
    remove supertest on windows production builds
    
    add symlink for mocha
    
    debug
    
    Revert "debug"
    
    This reverts commit 8916a05.
    
    Revert "add symlink for mocha"
    
    This reverts commit 3c60bef.
    
    windows workflow: adapt cypress path
    
    frontend admin tests
    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1f9b927 View commit details
    Browse the repository at this point in the history
  2. admin tests: refactor

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    688ca73 View commit details
    Browse the repository at this point in the history
  3. Add symlinks in ./src/node_modules for backwards compatibility.

    See "Note for plugin authors" section in Changelog.
    
    Some packages that are in use by plugins got a symlink in
    ./src/node_modules so that they still work after updating Etherpad. In
    the future don't require('etherpad_ep-lite/node_modules/dependency')
    anymore, but change this to require('dependency') and add the dependency
    to your plugin's package.json
    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    740af6a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a44f611 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c1a28b7 View commit details
    Browse the repository at this point in the history
  6. JSON.stringify error for debugging

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    23ce7bd View commit details
    Browse the repository at this point in the history
  7. Remove etherpad-cli-client devDependency.

    We use this package when testing rate limiting. We already install it in
    Docker, when running the Github workflow, so there is no need to install it by default.
    
    In contrast to other devDependencies this is not required in case you
    want to run the backend tests or check the code with eslint etc.
    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    519aba4 View commit details
    Browse the repository at this point in the history
  8. adminplugins; Fix reloading admin/plugins

    In some cases, when the server is restarting and the beforeEach hook
    tries to reload the admin/plugins page, it could fail.
    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5df101f View commit details
    Browse the repository at this point in the history
  9. remove npm i - is this still needed?

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c835c2a View commit details
    Browse the repository at this point in the history
  10. temporary: no mocha bin link

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    864c6f1 View commit details
    Browse the repository at this point in the history
  11. debug

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    4239d85 View commit details
    Browse the repository at this point in the history
  12. debug

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    811e0b8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a95c8e3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    81646b1 View commit details
    Browse the repository at this point in the history
  15. admin/plugins: fix test

    webzwo0i authored and SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9f2e8c9 View commit details
    Browse the repository at this point in the history
  16. updated package-lock.json.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    6bb0c2a View commit details
    Browse the repository at this point in the history
  17. updated package-lock.json.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    92e86d4 View commit details
    Browse the repository at this point in the history
  18. Removed fix for npm@6

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    52cf318 View commit details
    Browse the repository at this point in the history
  19. Updated dependencies.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    943e6e6 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6ed7cba View commit details
    Browse the repository at this point in the history
  21. Don't delete supertest.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    97f0ef7 View commit details
    Browse the repository at this point in the history
  22. Use development.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    25b4ece View commit details
    Browse the repository at this point in the history
  23. Use node env development.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9abc5a5 View commit details
    Browse the repository at this point in the history
  24. Use development version.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c243973 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    368a0a2 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    d6a3395 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    df9dd77 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    e046524 View commit details
    Browse the repository at this point in the history
  29. Updated jQuery.

    SamTV12345 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    02b826c View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d2ebb06 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Remove cd into src

    SamTV12345 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    60ae55d View commit details
    Browse the repository at this point in the history