-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating npm #5812
Closed
Closed
Updating npm #5812
Commits on Dec 18, 2023
-
Use
npm link
to install ep_etherpad-lite. This places a package.jsonfile in the root directory that references ./src directory as the file source for `ep_etherpad-lite`. Remove --legacy-peer-deps and --no-save when invoking npm. There is no need for them anymore, as we are bumping npm now to v8. ./src/package.json contains all dependencies of Etherpad core (package name ep_etherpad-lite) as before. The root directory's package.json file references ep_etherpad-lite and also contains references to any installed plugins. Remove npm from package.json as we depend on a recent version now; PATH is still updated as before, so in the future we may install a custom npm version again lint package-lock: update exception for sqlite3 remove node_modules and package.json during installDeps.sh update Dockerfile adapt minify windows build Fixed installOnWindows.bat remove node_modules from git bump minimal node/npm version in src/bin/functions.sh add changelog notes update installdeps fix dockerfile docker: test npm prefix set to the etherpad directory workflow: upgrade-from-latest-release needs to be adapted until next release is out Revert "docker: test npm prefix set to the etherpad directory" This reverts commit b856a24. use npm link --bin-links=false to prevent it from copying bin files temp fix for scripts as they are not installed to bin directory anymore adjust bin paths in Dockerfile Dockerfile add hint for npm link, dockerfile update dockerfile Revert "Fixed installOnWindows.bat" This reverts commit 70d0716. try installOnWindows; still TODO: no difference between production and development; no warning like in installDeps.sh before update - it just removes package* and node_modules so admins must be aware of the plugins they want to reinstall later update installOnWindows.bat update package-lock.json Dockerfile Dockerfile add file: scheme for lint check - needed as long as we have the plugin compatibility symlinks in ./src/node_modules fix installOnWindows upgrade-from-latest-release workflow: adapt cypress installation src/package.json: test-container fix path to _mocha; maybe revert this in case we enable bin-links again src/package.json: add test-on-windows script another try with test-on-windows, without using bin-links use bin-links on windows Revert "use bin-links on windows" This reverts commit f50ec2a. invoke mocha binary on windows run npm i once on windows, to make bin files available - why? remove supertest on windows production builds add symlink for mocha debug Revert "debug" This reverts commit 8916a05. Revert "add symlink for mocha" This reverts commit 3c60bef. windows workflow: adapt cypress path frontend admin tests
Configuration menu - View commit details
-
Copy full SHA for 1f9b927 - Browse repository at this point
Copy the full SHA 1f9b927View commit details -
Configuration menu - View commit details
-
Copy full SHA for 688ca73 - Browse repository at this point
Copy the full SHA 688ca73View commit details -
Add symlinks in ./src/node_modules for backwards compatibility.
See "Note for plugin authors" section in Changelog. Some packages that are in use by plugins got a symlink in ./src/node_modules so that they still work after updating Etherpad. In the future don't require('etherpad_ep-lite/node_modules/dependency') anymore, but change this to require('dependency') and add the dependency to your plugin's package.json
Configuration menu - View commit details
-
Copy full SHA for 740af6a - Browse repository at this point
Copy the full SHA 740af6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a44f611 - Browse repository at this point
Copy the full SHA a44f611View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1a28b7 - Browse repository at this point
Copy the full SHA c1a28b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23ce7bd - Browse repository at this point
Copy the full SHA 23ce7bdView commit details -
Remove etherpad-cli-client devDependency.
We use this package when testing rate limiting. We already install it in Docker, when running the Github workflow, so there is no need to install it by default. In contrast to other devDependencies this is not required in case you want to run the backend tests or check the code with eslint etc.
Configuration menu - View commit details
-
Copy full SHA for 519aba4 - Browse repository at this point
Copy the full SHA 519aba4View commit details -
adminplugins; Fix reloading admin/plugins
In some cases, when the server is restarting and the beforeEach hook tries to reload the admin/plugins page, it could fail.
Configuration menu - View commit details
-
Copy full SHA for 5df101f - Browse repository at this point
Copy the full SHA 5df101fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c835c2a - Browse repository at this point
Copy the full SHA c835c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 864c6f1 - Browse repository at this point
Copy the full SHA 864c6f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4239d85 - Browse repository at this point
Copy the full SHA 4239d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 811e0b8 - Browse repository at this point
Copy the full SHA 811e0b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a95c8e3 - Browse repository at this point
Copy the full SHA a95c8e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81646b1 - Browse repository at this point
Copy the full SHA 81646b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f2e8c9 - Browse repository at this point
Copy the full SHA 9f2e8c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bb0c2a - Browse repository at this point
Copy the full SHA 6bb0c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92e86d4 - Browse repository at this point
Copy the full SHA 92e86d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52cf318 - Browse repository at this point
Copy the full SHA 52cf318View commit details -
Configuration menu - View commit details
-
Copy full SHA for 943e6e6 - Browse repository at this point
Copy the full SHA 943e6e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ed7cba - Browse repository at this point
Copy the full SHA 6ed7cbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f0ef7 - Browse repository at this point
Copy the full SHA 97f0ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b4ece - Browse repository at this point
Copy the full SHA 25b4eceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9abc5a5 - Browse repository at this point
Copy the full SHA 9abc5a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c243973 - Browse repository at this point
Copy the full SHA c243973View commit details -
Configuration menu - View commit details
-
Copy full SHA for 368a0a2 - Browse repository at this point
Copy the full SHA 368a0a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6a3395 - Browse repository at this point
Copy the full SHA d6a3395View commit details -
Configuration menu - View commit details
-
Copy full SHA for df9dd77 - Browse repository at this point
Copy the full SHA df9dd77View commit details -
Configuration menu - View commit details
-
Copy full SHA for e046524 - Browse repository at this point
Copy the full SHA e046524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b826c - Browse repository at this point
Copy the full SHA 02b826cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2ebb06 - Browse repository at this point
Copy the full SHA d2ebb06View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 60ae55d - Browse repository at this point
Copy the full SHA 60ae55dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.