Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next-page-disabled-if-zero-page #6457

Merged
merged 1 commit into from
Jun 18, 2024
Merged

next-page-disabled-if-zero-page #6457

merged 1 commit into from
Jun 18, 2024

Conversation

samyakj023
Copy link
Contributor

fixes #6455

Screenshot (152)

@heldersepu
Copy link
Contributor

A bit more comments on the PR will be great!
... maybe explain what the problem was and what are you fixing

@samyakj023
Copy link
Contributor Author

earlier problem was that in case of zero page next page is not disabled then on clicking next page counter increases on every click
now if there is no next page next page will be disabled

@SamTV12345
Copy link
Member

Thanks for the fix :)

@SamTV12345 SamTV12345 merged commit 161dd72 into ether:develop Jun 18, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heldersepu heldersepu heldersepu approved these changes

@SamTV12345 SamTV12345 SamTV12345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paginator should be disabled with no pads
3 participants
@samyakj023 @heldersepu @SamTV12345