Fix SEO field focus keywords on Craft 4. #444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #431 and fixes #407 .
I thought I would investigate the issue with the focus keywords section on Craft version 4 and attempt to figure out what's happening. As far as I can tell, it's related to a change with the drafts / elements editor in Craft 4 and using the approach recommended in a similar thread, the focus keywords section appears to be working.
The override of
window.Craft.ElementEditor.prototype.init
inSeoField.js
feels like a very poor solution, but I needed to ensure this code runs after the Craft ElementEditor is fully initialized.After limited testing it appears to fix the focus keywords section, but if anybody wants to test this works, please have a try using the fork in your
composer.json
.