Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SEO field focus keywords on Craft 4. #444

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

dyerc
Copy link
Contributor

@dyerc dyerc commented Feb 27, 2023

Fixes #431 and fixes #407 .

I thought I would investigate the issue with the focus keywords section on Craft version 4 and attempt to figure out what's happening. As far as I can tell, it's related to a change with the drafts / elements editor in Craft 4 and using the approach recommended in a similar thread, the focus keywords section appears to be working.

The override of window.Craft.ElementEditor.prototype.init in SeoField.js feels like a very poor solution, but I needed to ensure this code runs after the Craft ElementEditor is fully initialized.

After limited testing it appears to fix the focus keywords section, but if anybody wants to test this works, please have a try using the fork in your composer.json.

@kevinmu17
Copy link

kevinmu17 commented Feb 27, 2023

For testers: composer.json

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/dyerc/seo"
    }
  ],
  "require": {
    "ether/seo": "dev-bugfix-keywords",
  }

run composer update

@dyerc
Copy link
Contributor Author

dyerc commented Feb 27, 2023

what to put in the composer.json?

If you reference my repository in composer.json:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/dyerc/seo"
        }
    ]

Then run:

composer require ether/seo:dev-bugfix-keywords

@kevinmu17
Copy link

This fixed the issue, thanks! hope ether will merge very soon!

@dennis-vdw
Copy link

Thanks @dyerc , this fixed the issue!

@Tam Tam changed the base branch from v4 to v4-dev April 12, 2023 14:04
@Tam Tam merged commit eb5014d into ethercreative:v4-dev Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus keywords fields not working Focus keywords are wiped after upgrading to 4.0.0 and can't save new ones
4 participants