Added RecurringPayment contract example #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsaether
approved these changes
Apr 23, 2018
| ); | ||
|
|
||
| emit PaymentScheduled(currentScheduledTransaction, recipient, paymentValue); | ||
| } |
There was a problem hiding this comment.
My suggestion would be to add a withdraw() function to pull the rest of the funds out of this contract by owner. This would be in the case that the owner is done with the recurring payment service, cancels the next call to the contract, and takes all of their funds out. Not need for this basic example, but something to include to encourage future developers to think about it.
There was a problem hiding this comment.
I would also consider adding in a cancel function which is relevant to many low hanging use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial implementation for recurring payment using EAC.
This is not production ready at any means. It's mean to present the design pattern that can be used with EAC.