Treat block and timestamp buckets equally and separately #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e00dan
approved these changes
Oct 19, 2018
| const nextBuckets = await this.getNextBuckets(latest); | ||
| const afterNextBuckets = await this.getAfterNextBuckets(latest); | ||
|
|
||
| return currentBuckets.concat(nextBuckets).concat(afterNextBuckets); |
There was a problem hiding this comment.
This line is completely okay, but worth to mention it would be also possible to do:
Suggested change
| return currentBuckets.concat(nextBuckets).concat(afterNextBuckets); | |
| return return [...currentBuckets, ...nextBuckets, ...afterNextBuckets]; |
There was a problem hiding this comment.
New-school vs old-school 👍
|
|
||
| public async stop() { | ||
| await Promise.all(this.buckets.map(b => b.stop())); | ||
| return; |
There was a problem hiding this comment.
No need for return here. It's implicit.
Suggested change
| return; |
There was a problem hiding this comment.
It's needed, as I don't want to return Promise<void[]>
There was a problem hiding this comment.
Why not have these functions return Promise<boolean> instead? This would probably need an extra reduce to check all values are true but it would better than returning void I think
There was a problem hiding this comment.
What should happen if some are not true ?
Pull Request Test Coverage Report for Build 2182
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another (hopefully last) attempt to simplify and optimize bucket handling.