Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP editor apprenticeship meeting 15 #119

Closed
poojaranjan opened this issue Mar 23, 2022 · 4 comments
Closed

EIP editor apprenticeship meeting 15 #119

poojaranjan opened this issue Mar 23, 2022 · 4 comments

Comments

@poojaranjan
Copy link
Member

Date and Time

Tuesday, Apr 05, 2022, at 15:00 UTC

Location

Join Zoom Meeting
https://us02web.zoom.us/j/81211958072?pwd=ZU5BSVkvNHZWb0s1RnpqSzBLRFI5QT09

Agenda

  • Go over some of the EIP GitHub Issues & Pull Requests as a walk through the editing process.
  • Q&A

Please leave a comment for anything else you would like to learn/discuss.

@poojaranjan
Copy link
Member Author

Some PRs to be discussed

EIP Editor's review requested by author(s):

  • PR-4430
  • PR-4858 and PR-4779
  • PR-4841
  • PR-4835
  • PR-4824
  • PR-4513

@lightclient
Copy link

done! thanks for aggregating these!

@poojaranjan
Copy link
Member Author

poojaranjan commented Apr 5, 2022

Summary

Recording: https://youtu.be/52WuA82y7I4

(Status after today's review)

  • PR-4430 - Approved & merged
  • PR-4858 (left edit comments) and PR-4779 (for the same EIP)
  • PR-4841 - vet the idea
  • PR-4835 - requested changes, merged
  • PR-4824 - Overall good, Waiting on title change.
  • PR-4513 - Approved & merged
  • PR-4974 - Overall looks good, requested changes
  • PR-4886 - Review comments left

@poojaranjan
Copy link
Member Author

Closing in favor of #124

This was referenced Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants