Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faucets #21

Closed
ligi opened this issue Feb 8, 2019 · 6 comments
Closed

Add faucets #21

ligi opened this issue Feb 8, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@ligi
Copy link
Member

ligi commented Feb 8, 2019

I think this could be very practical. Also a defined token for an address.In KEthereum I use a token like this for it:

"https://goerli-faucet.slock.it/?address=%address%"

@ligi ligi added the question Further information is requested label Feb 8, 2019
@bmann
Copy link
Contributor

bmann commented Feb 9, 2019

Oh this would be great!

Don’t know about the token — feels like faucet as a URI field array makes sense, not sure if embedding the token into the JSON makes sense.

@ligi
Copy link
Member Author

ligi commented Feb 9, 2019

great! to clarify the token - this address will be prefilled in the address field in the faucet if available. This makes UX much better as users do not need to enter it then. I would signal to include it.

@bmann
Copy link
Contributor

bmann commented Feb 10, 2019

Can I see a couple of examples to better understand?

Also, I filed an issue for a definitions page. We can define what each field is so people can understand it’s usage.

@ligi
Copy link
Member Author

ligi commented Feb 10, 2019

e.g.

"https://goerli-faucet.slock.it/?address=%address%"

would be a faucet url - and the wallet for example would replace %address% with the users current address

@ligi
Copy link
Member Author

ligi commented Feb 28, 2019

faucets should be an array of object with the properties: url,address, with_tokens, max_amount

not 100% about tokens and amount - perhaps as list of address+amount?

@pedrouid pedrouid mentioned this issue Mar 20, 2019
@pedrouid
Copy link
Collaborator

LGTM 👍 Let's just go ahead and add this one to the spec

@ligi ligi added enhancement New feature or request and removed question Further information is requested labels Mar 27, 2019
pedrouid added a commit that referenced this issue Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants