Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Toki Network and Toki Testnet #1426

Merged
merged 7 commits into from
Aug 28, 2022
Merged

Add Toki Network and Toki Testnet #1426

merged 7 commits into from
Aug 28, 2022

Conversation

evanwang0
Copy link
Contributor

No description provided.

ligi
ligi requested changes Aug 18, 2022
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short name must be unique - but found TOKI more than once
also rebase to master please
and the icon should have width and height fields

@evanwang0
Copy link
Contributor Author

Fixed. I modified the README slightly, because it is inconsistent. Please advise if the copy should be adjusted.

ligi
ligi requested changes Aug 20, 2022
View reviewed changes
_data/icons/toki.json Outdated Show resolved Hide resolved
ligi
ligi requested changes Aug 22, 2022
View reviewed changes
_data/icons/toki.json Show resolved Hide resolved
@ligi
Copy link
Member

ligi commented Aug 28, 2022

/rebase

@evanwang0
Copy link
Contributor Author

Rebased

@evanwang0
Copy link
Contributor Author

@ligi Remove network?

ligi
ligi requested changes Aug 28, 2022
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea - and copy the other jsons schema / style introduced in #1509 - @ashutoshpw can you maybe add to the readme a section about this?

_data/chains/eip155-8654.json Outdated Show resolved Hide resolved
_data/chains/eip155-8655.json Outdated Show resolved Hide resolved
@ashutoshpw
Copy link
Contributor

yea - and copy the other jsons schema / style introduced in #1509 - @ashutoshpw can you maybe add to the readme a section about this?

Will be adding this soon.

@ashutoshpw
Copy link
Contributor

This is auto-formatted if you have prettier extension installed in VS Code. If you don't have extension installed, you can format the files by running this command in project root directory. (You should have NodeJS installed in your system for this to run)

npx prettier --write --ignore-unknown _data

@evanwang0
Copy link
Contributor Author

@ashutoshpw I formatted the files after I saw the error in the CI. :)

@ligi ligi merged commit a853c91 into ethereum-lists:master Aug 28, 2022
hoanguyenkh pushed a commit to AstraProtocol/chains that referenced this pull request Aug 29, 2022
@evanwang0 @ligi
Add Toki Network and Toki Testnet (ethereum-lists#1426)
def3f08 
* Add Toki Network and Toki Testnet

* Change Toki Testnet short name, update Toki icon to include width & height, and update README.md

* Reorder Toki icon fields for consistency

* Update _data/icons/toki.json

Co-authored-by: ligi <ligi@ligi.de>

* Update SVG to have width/height defined

* Remove network property from Toki Networks

* Run prettier on Toki Networks

Co-authored-by: ligi <ligi@ligi.de>
hoanguyenkh pushed a commit to AstraProtocol/chains that referenced this pull request Aug 29, 2022
@evanwang0 @ligi
Add Toki Network and Toki Testnet (ethereum-lists#1426)
19a6267 
* Add Toki Network and Toki Testnet

* Change Toki Testnet short name, update Toki icon to include width & height, and update README.md

* Reorder Toki icon fields for consistency

* Update _data/icons/toki.json

Co-authored-by: ligi <ligi@ligi.de>

* Update SVG to have width/height defined

* Remove network property from Toki Networks

* Run prettier on Toki Networks

Co-authored-by: ligi <ligi@ligi.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanwang0 @ligi @ashutoshpw