Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Filecoin networks. #1567

Merged
merged 9 commits into from
Oct 19, 2022
Merged

add Filecoin networks. #1567

merged 9 commits into from
Oct 19, 2022

Conversation

raulk
Copy link
Contributor

@raulk raulk commented Sep 8, 2022

The Filecoin team at Protocol Labs shipped the Filecoin Virtual Machine to mainnet in July 2022, during the Skyr network upgrade.

Since then, we've been working on the first user-programmable execution runtime, called FEVM (Filecoin EVM). It will be fully compatible with Ethereum tooling. For this reason, we would like to allocate chain IDs for all Filecoin networks, including:

  • Mainnet
  • Buildernet
  • Wallaby testnet (bleeding edge network)
  • Butterfly testnet (early pre-release testing)
  • Calibration testnet (mainnet-like conditions)
  • Local devnets

Full project roadmap here.

@raulk
Copy link
Contributor Author

raulk commented Sep 12, 2022

@ligi any chance we could get a review here? 🙏

"name": "Filecoin — Mainnet",
"chain": "FIL",
"status": "incubating",
"rpc": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rpc we can add:

"rpc" [
     "https://api.node.glif.io/rpc/v0"
].

Copy link
Contributor Author

@raulk raulk Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I was under the impression that these RPCs needed to follow the Ethereum JSON-RPC interface, hence why I left them blank while that implementation is underway. Happy to add these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Can leave it blank for now, this is for EVM flavoured chains only, while the rest of CAIP is setting the standards on a per chain basis for things like wallet clients that want to talk across them.

"name": "Filecoin — Wallaby testnet",
"chain": "FIL",
"status": "incubating",
"rpc": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rpc we can add:

"rpc" [
     "https://wallaby.node.glif.io/rpc/v0"
].

"name": "Filecoin — Calibration testnet",
"chain": "FIL",
"status": "incubating",
"rpc": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rpc we can add:

"rpc" [
     "https://api.calibration.node.glif.io/rpc/v0"
].

"decimals": 18
},
"infoURL": "https://filecoin.io",
"shortName": "filecoin",
Copy link
Contributor

@eshon eshon Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it
shortname: "fil",
?

Copy link
Contributor Author

@raulk raulk Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen the Filecoin network addressed as purely "fil", or "fil network".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just basing this on https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-1.json#L18 but can ask Boris about this tomorrow

_data/chains/eip155-314.json Outdated Show resolved Hide resolved
@eshon
Copy link
Contributor

eshon commented Sep 15, 2022

Please merge together with #1590

@raulk
Copy link
Contributor Author

raulk commented Sep 16, 2022

I think all requested changes have been applied now.

@raulk
Copy link
Contributor Author

raulk commented Oct 3, 2022

Hey @bmann -- I think all requested changes have been addressed here. What would be holding us back now from merging this PR and #1590? Thank you!

@bmann bmann merged commit 70c7e0d into ethereum-lists:master Oct 19, 2022
q9f added a commit to filecoin-project/FIPs that referenced this pull request Apr 20, 2023
jennijuju pushed a commit to filecoin-project/FIPs that referenced this pull request May 16, 2023
* fip-0039: update chain ids

ref: ethereum-lists/chains#1567

* fix fip number in references

* remove chainid considerations from fip-0039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants