Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add taraxa chains to chainlist #1805

Merged
merged 12 commits into from
Dec 17, 2022
Merged

add taraxa chains to chainlist #1805

merged 12 commits into from
Dec 17, 2022

Conversation

VargaElod23
Copy link
Contributor

No description provided.

ligi
ligi requested changes Nov 1, 2022
View reviewed changes
_data/icons/taraxa.json Outdated
Comment on lines 3 to 4
"width": 512,
"height": 512,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size seems to be wrong

identify QmQhdktNyBeXmCaVuQpi1B4yXheSUKrJA17L4wpECKzG5D 19:30:11
QmQhdktNyBeXmCaVuQpi1B4yXheSUKrJA17L4wpECKzG5D PNG 310x310 310x310+0+0 8-bit sRGB 28094B 0.000u 0:00.000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm weird, our designer named it 512. I'm addressing it now:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ligi Corrected to310x310 . Thanks for the review!

ligi
ligi requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the explorer does not really seem to support EIP3091 when it comes to blocks

@VargaElod23
Copy link
Contributor Author

VargaElod23 commented Nov 4, 2022 •
edited

@ligi not in the current version but we're weeks away from releasing the next version, which, besides having additional features, supports EIP-3091 too. However, in this case I can remove it until.

@VargaElod23
Copy link
Contributor Author

@ligi updated without EIP-3091

ligi
ligi requested changes Nov 8, 2022
View reviewed changes
_data/chains/eip155-841.json Outdated Show resolved Hide resolved
_data/chains/eip155-842.json Outdated Show resolved Hide resolved
VargaElod23 and others added 2 commits November 9, 2022 22:06
@VargaElod23 @ligi
Update _data/chains/eip155-841.json
4cc9b87 
Co-authored-by: ligi <ligi@ligi.de>
@VargaElod23 @ligi
Update _data/chains/eip155-842.json
9e60b80 
Co-authored-by: ligi <ligi@ligi.de>
ligi
ligi requested changes Dec 4, 2022
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short name must be unique - but found TARA more than once

@VargaElod23
Copy link
Contributor Author

@ligi fixed

ligi
ligi reviewed Dec 12, 2022
View reviewed changes
_data/icons/taraxa.json Outdated Show resolved Hide resolved
ligi
ligi requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the prettier to format your json according to the style defined here
e.g. run npx prettier --write _data/*/*.json

@VargaElod23
Copy link
Contributor Author

@ligi formatted per your request

@ligi ligi merged commit d398b15 into ethereum-lists:master Dec 17, 2022
@MatusKysel MatusKysel mentioned this pull request Dec 21, 2022
Closed
@VargaElod23 VargaElod23 mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi approved these changes

@Saberhabeelshohdy Saberhabeelshohdy Saberhabeelshohdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@VargaElod23 @ligi @Saberhabeelshohdy @Elod23