Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix The Bifrost Testnet Information #2252

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix The Bifrost Testnet Information #2252

merged 3 commits into from
Feb 9, 2023

Conversation

seonggwonyoon
Copy link
Contributor

Hello I am a devops engineer working at thebifrost.
Removed RPC and updated shortName.

ligi
ligi requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not resolve your CID with ipfs get in a reasonable time - and before having a back and forth here I require you to put it in iconDownload. Before this back and forth did cost me a lot of time that I do not have.

@seonggwonyoon
Copy link
Contributor Author

I could not resolve your CID with ipfs get in a reasonable time - and before having a back and forth here I require you to put it in iconDownload. Before this back and forth did cost me a lot of time that I do not have.

Added CID to iconDownload

@ligi ligi merged commit 5e53437 into ethereum-lists:master Feb 9, 2023
@seonggwonyoon seonggwonyoon deleted the fix/eip155-49088 branch February 9, 2023 16:39
@seonggwonyoon seonggwonyoon mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seonggwonyoon @ligi