This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Update README #106
Merged
Update README #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
readme
branch
2 times, most recently
from
e0240c7
to
0f8ba52
Compare
CamonZ
reviewed
Jul 3, 2017
README.md
Outdated
|
|
||
| ```sh | ||
| mkdir build; cd build | ||
| cmake .. |
There was a problem hiding this comment.
Is there a difference between .. and ../, also it might be good to point out this is the step where you pass the -DETHASHCUDA=ON option
README.md
Outdated
| mkdir build; cd build | ||
| cmake .. | ||
| cmake --build . | ||
| ``` |
There was a problem hiding this comment.
This is linux specific but maybe add a make install at the end so the binary gets copied to /usr/local/bin
There was a problem hiding this comment.
yes, it's how I built and installed from master on Ubuntu 17
|
I extended the "building from source" section. How does it look now? |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.