Skip to content
This repository has been archived by the owner on Apr 24, 2022. It is now read-only.

WIP: ethminer-ProgPoW rebase - spec v0.9.2 #1766

Closed

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Dec 9, 2018

WARNING: only cuda tested.
with https://github.com/EthersocialNetwork/go-ethereum/tree/progpow-v0.9.2
(modified version of the original work by Martin)

manually rebased on top of the current master branch. + additional OpenCL fix + cuda8 fix

/share/ProgPoW/build/ethminer/ethminer --noeval -v 3 --cuda-devices 0 -U -P http://127.0.0.1:8548
image

I'm not try to merge this PR. this is just a (manually) rebased code.
but we can test / study and use it as a reference work to merge ProgPoW into the ethminer codebase.

image

ChangeLog

  • CPU verifier temporally enabled (12/14)

@ddobreff
Copy link
Collaborator

ddobreff commented Dec 9, 2018

There are already 2 PRs for progpow
integration, can’t you just work on one?

@hackmod
Copy link
Contributor Author

hackmod commented Dec 9, 2018

yes. There are already ProgPoW PR by @MariusVanDerWijden,
and this PR is just a rebase work on top of the latest master branch.

this PR could be regarded as a reference work

@ghost ghost mentioned this pull request Dec 9, 2018
@ghost
Copy link

ghost commented Dec 9, 2018

@ddobreff I've just closed my PR

@ghost
Copy link

ghost commented Dec 9, 2018

@hackmod Can you fix these?

CMake Warning (dev) at ethminer/CMakeLists.txt:17 (find_package):
  Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables.
  Run "cmake --help-policy CMP0074" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
  CMake variable CLI11_ROOT is set to:
    C:/.hunter/_Base/951e8da/4717139/c15df5a/Install
  Environment variable CLI11_ROOT is set to:
    C:/.hunter/_Base/951e8da/4717139/c15df5a/Install
  For compatibility, CMake is ignoring the variable.
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
CUDA_nvrtc_LIBRARY
    linked by target "ethash-cuda" in directory C:/projects/ethminer/libethash-cuda
-- Configuring incomplete, errors occurred!
See also "C:/projects/ethminer/build/CMakeFiles/CMakeOutput.log".
See also "C:/projects/ethminer/build/CMakeFiles/CMakeError.log".

@ddobreff ddobreff self-requested a review December 9, 2018 09:23
Copy link
Collaborator

@ddobreff ddobreff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case of accidental merge

@hackmod hackmod force-pushed the progpow-master-rebase-v0.9.2 branch 3 times, most recently from 33e5664 to 0c70185 Compare December 10, 2018 17:47
@hackmod
Copy link
Contributor Author

hackmod commented Dec 10, 2018

rebased. fixed travis error

@ghost ghost mentioned this pull request Dec 10, 2018
@hackmod
Copy link
Contributor Author

hackmod commented Dec 13, 2018

binaries are available at https://github.com/hackmod/ethminer/releases/tag/v0.9.2-progpow

  • only CUDA supported
  • you can test it locally with --noevel option like as follow
    ethminer --noeval -v 3 --cuda-devices 0 -U -P http://127.0.0.1:8545

See also progpow testnet:

@MariusVanDerWijden
Copy link
Collaborator

MariusVanDerWijden commented Dec 13, 2018

Thank you for all the work!
However mining currently fails with

Unexpected error CUDA error in func compileKernel at line 396 calling cuModuleLoadDataEx(&m_module, ptx, 6, jitOpt, jitOptVal) failed with error CUDA_ERROR_INVALID_PTX on CUDA device 65:00.0

PS- sorry, didn't mean to close the PR

@hackmod
Copy link
Contributor Author

hackmod commented Dec 13, 2018

Thank you for all the work!
However mining currently fails with

Unexpected error CUDA error in func compileKernel at line 396 calling cuModuleLoadDataEx(&m_module, ptx, 6, jitOpt, jitOptVal) failed with error CUDA_ERROR_INVALID_PTX on CUDA device 65:00.0

thankyou for your feedback~

did you download binary from my repo?

for some cases, cmake detect wrong libnvrtc*so path and link different version of the nvrtc and it makes some trouble with cuModuleLoadDataEx()

@hackmod
Copy link
Contributor Author

hackmod commented Dec 14, 2018

fixed some mistakes / CPU verifier temporary enabled for testing

@hackmod hackmod force-pushed the progpow-master-rebase-v0.9.2 branch 3 times, most recently from 3678df4 to 5bdc6c8 Compare December 17, 2018 15:25
 * misc fixes after manual rebase
 * use prog_seed
 * revert WORKSIZE name to GROUP_SIZE
@hackmod
Copy link
Contributor Author

hackmod commented Dec 18, 2018

now OpenCL supported!

  • extract compileKernel()
  • compileKernel every 50 blocks

https://github.com/hackmod/ethminer/releases/tag/v0.9.2-opencl-win-1218

  • binaries snapshot for testing: temporary disabled CUDA, windows binaries only.

@hackmod
Copy link
Contributor Author

hackmod commented Dec 19, 2018

fixed epoch change issue
https://github.com/hackmod/ethminer/releases/tag/v0.9.2-opencl-win-1219

  • OpenCL: fixed setArg issue after epoch change
  • CUDA: fixed manual rebase mistake. (fix incompatible driver context error after epoch change)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants