bug setActiveConnection always error

[wanyvic]

No description provided.

[MariusVanDerWijden]

Isn't this equal to this? Would save us the found bool

    for (size_t idx = 0; idx < m_Settings.connections.size(); idx++)
        if (boost::iequals(m_Settings.connections[idx]->str(), _connstring))
        {
            setActiveConnectionCommon(idx);
            return;
        }
    throw std::runtime_error("Not found.");

Cool find by the way, Don't know how this could slide by

[wanyvic]

Isn't this equal to this? Would save us the found bool

    for (size_t idx = 0; idx < m_Settings.connections.size(); idx++)
        if (boost::iequals(m_Settings.connections[idx]->str(), _connstring))
        {
            setActiveConnectionCommon(idx);
            return;
        }
    throw std::runtime_error("Not found.");

Cool find by the way, Don't know how this could slide by

much better