Utilize zokrates-js/node build variant #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: myronrotter myronrotter01@t-online.de
Description
Usage of the privacy package
@baseline-protocol/privacy
for Node.js applications fails due to the fact thatzokrates-js
uses the bundler variant leveraging ES2016 features by default.Related Issue
#224
Motivation and Context
One acceptance criteria of #224 consists of refactoring the existing the codebase to import and use
@baseline-protocol/privacy
.However, importing mentioned package fails with the error
When refactoring the privacy package to use
zokrates-js/node
instead ofzokrates-js
, this error gets resolved. This variant usesrequire
instead ofimport
in the entrypoint, makingzokrates-js/node
a valid CommonJS package. See https://zokrates.github.io/toolbox/zokrates_js.html#importing for more information.Result
Node.js applications should now be able to use
@baseline-protocol/privacy
out-of-the-box without adding a transpilation step like Typescript or Babel, including the radish34 demo project.How Has This Been Tested
The following steps were made:
npm test
in the privacy packagenpm run build
successfullyScreenshots (if appropriate)
Types of changes
Checklist