This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
Move everything over to hardhat #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR contains no changes to contract functionality. |
smartcontracts
added
Category: Cleanup
Category: Enhancement
maurelian
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
This LGTM.
I confirmed that the only changes to solidity files are minor, and won't introduce meaningful logic changes.
I also see that where a test is skipped, there is a note, which will be useful for future reference: // TODO: Appears to be failing because of a bug in smock.
Also, I ran the build and test processes to confirm that they worked.
Tests had: 943 passing, 39 pending
(For reference master which has 950 passing, 32 pending)
I agree that since we know these tests should work except for a bug in smock its fine to move forward with this.
maurelian
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Got hardhat to work * Fix build structure * Fix build process, hopefully
maurelian
pushed a commit
that referenced
this pull request
Feb 2, 2021
build: fix multirelay: permissions contract: style fix lint: fix Move everything over to hardhat (#208) * Got hardhat to work * Fix build structure * Fix build process, hopefully Rename new contract and style improvements save save fix interface type cast undo bad fix and check-in pretty good tests (still buggy)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following things:
hardhat, gets rid of any dependencies onbuidler.// +build ovmsyntax with the newer// @unsupported: ovmsyntax.0.5.0as a compiler version.Notes
smock. I think the value of getting everything updated to hardhat probably outweighs the value of waiting to squash these bugs.Contributing Agreement