Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added $GRND token w/contract info on Optimism, Polygon, and Ethereum #769

Closed
wants to merge 6 commits into from
+42 −0
Closed

added $GRND token w/contract info on Optimism, Polygon, and Ethereum #769

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08ebcd5
added $GRND token w/contract info on Optimism, Polygon, and Ethereum
ipfsnut Apr 7, 2024
d1d53c0
added Base Network contract
ipfsnut Apr 24, 2024
00bdeab
Update data.json
ipfsnut Apr 30, 2024
0d36501
Delete .gitpod.yml
ipfsnut Apr 30, 2024
f289700
Update data.json
ipfsnut May 1, 2024
dfda040
Update data.json
ipfsnut May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions data/GRND/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
hamdiallam marked this conversation as resolved.
Show resolved Hide resolved
"name": "Token Name",
"symbol": "SYMBOL",
"decimals": 18,
"description": "The token of the UNDRGRND Art Community",
"website": "https://undrgrnd.io",
"twitter": "@undrgrnd_nft",
"tokens": {
"ethereum": {
"address": "0x9816082D089faD585B0735dcaf15147bBB9A4C4d"
},
"optimism": {
"address": "0x337919Bc5737D046Dd4b559D2663aF7B0948EfE6"
},
"polygon": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this polygon entry? Polygon is not apart of the superchain

Please run the validation script locally and ensure it's passing so that this feedback loop is a but faster

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polygon removed. We should be good to go!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where the validation script is - not to waste too much of your time, but if there's a link to it I am happy to run it. I'm working on doing this for $PAGE as well, and using the Base bot for the first time, so just learning this process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nw! this is good signal to get our readme updated. Noticed the section about validation doesn't specify the validation command. I'll get that updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more things to fix

2024-05-01T03:08:59.5147639Z error: GRND on chain ethereum token 0x9816082D089faD585B0735dcaf15147bBB9A4C4d has incorrect symbol
2024-05-01T03:08:59.5149563Z error: GRND on chain ethereum token 0x9816082D089faD585B0735dcaf15147bBB9A4C4d has incorrect name. Got GRND
2024-05-01T03:08:59.5151770Z error: GRND on chain optimism token 0x337919Bc5737D046Dd4b559D2663aF7B0948EfE6 has incorrect symbol
2024-05-01T03:08:59.5153278Z error: GRND on chain optimism token 0x337919Bc5737D046Dd4b559D2663aF7B0948EfE6 has incorrect name. Got GRND
2024-05-01T03:08:59.5154525Z error: GRND on chain base token 0x7E00780C65D0291E5210fC208ABce0C5A966d538 has incorrect symbol
2024-05-01T03:08:59.5155646Z error: GRND on chain base token 0x7E00780C65D0291E5210fC208ABce0C5A966d538 has incorrect name. Got GRND

The data fields need to match what's onchain, with overrides set if that's not possible

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I had left in the templated Name and Symbol fields at the top, as a result of my effort to locate the formatting error. Setting those to Name and Symbol respectively did not work well with the token named GRND with a symbol of GRND. My bad! We should be good now though.

"address": "0xC41cFdc0A3199eE6b22bd3c2e6624aC10695e510"
},
"base": {
"address": "0x7E00780C65D0291E5210fC208ABce0C5A966d538"
}
}
}


21 changes: 21 additions & 0 deletions data/GRND/logo.svg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.