Skip to content

Commit

Permalink
packages: remove unmaintained javascript (#10613)
Browse files Browse the repository at this point in the history
* packages: remove unmaintained javascript

This commit removes the following packages from the monorepo:
- `common-ts`
- `contracts-ts`
- `core-utils`
- `fee-estimation`
- `web3js-plugin`

These packages are not maintained. `chain-mon` and the `sdk` still
exist but are pending deprecation.

* readme: update

* mergify: leftover references
  • Loading branch information
tynes committed May 22, 2024
1 parent f2e5a7a commit 07d7010
Show file tree
Hide file tree
Showing 119 changed files with 4,669 additions and 74,239 deletions.
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"changelog": ["@changesets/changelog-github", { "repo": "ethereum-optimism/optimism" }],
"commit": false,
"fixed": [],
"linked": [["@eth-optimism/contracts-bedrock", "@eth-optimism/contracts-ts"]],
"linked": [],
"access": "public",
"baseBranch": "develop",
"updateInternalDependencies": "patch",
Expand Down
53 changes: 2 additions & 51 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -725,28 +725,6 @@ jobs:
name: Upload coverage
command: codecov --verbose --clean --flags <<parameters.coverage_flag>>

contracts-ts-tests:
docker:
- image: <<pipeline.parameters.ci_builder_image>>
resource_class: medium
steps:
- checkout
- attach_workspace: { at: "." }
- restore_cache:
name: Restore pnpm Package Cache
keys:
- pnpm-packages-v2-{{ checksum "pnpm.lock.yaml" }}
- check-changed:
patterns: sdk,contracts-bedrock,contracts
# populate node modules from the cache
- run:
name: Install dependencies
command: pnpm install:ci
- run:
name: Check generated and build
command: pnpm generate:check
working_directory: packages/contracts-ts

sdk-next-tests:
docker:
- image: <<pipeline.parameters.ci_builder_image>>
Expand Down Expand Up @@ -863,14 +841,6 @@ jobs:
- pnpm-packages-v2-{{ checksum "pnpm-lock.yaml" }}
- check-changed:
patterns: packages
- run:
name: Check common-ts
command: npx depcheck
working_directory: packages/common-ts
- run:
name: Check core-utils
command: npx depcheck
working_directory: packages/core-utils
- run:
name: Check sdk
command: npx depcheck
Expand Down Expand Up @@ -1675,18 +1645,6 @@ workflows:
jobs:
- pnpm-monorepo:
name: pnpm-monorepo
- js-lint-test:
name: common-ts-tests
coverage_flag: common-ts-tests
package_name: common-ts
requires:
- pnpm-monorepo
- js-lint-test:
name: core-utils-tests
coverage_flag: core-utils-tests
package_name: core-utils
requires:
- pnpm-monorepo
- contracts-bedrock-tests:
requires:
- pnpm-monorepo
Expand All @@ -1701,21 +1659,14 @@ workflows:
name: chain-mon-tests
coverage_flag: chain-mon-tests
package_name: chain-mon
dependencies: "(common-ts|contracts-bedrock|core-utils|sdk)"
requires:
- pnpm-monorepo
- js-lint-test:
name: contracts-ts-tests
coverage_flag: contracts-ts-tests
package_name: contracts-ts
dependencies: '(contracts-bedrock|contracts-ts)'
dependencies: "(contracts-bedrock|sdk)"
requires:
- pnpm-monorepo
- js-lint-test:
name: sdk-tests
coverage_flag: sdk-tests
package_name: sdk
dependencies: "(contracts-bedrock|core-utils)"
dependencies: "contracts-bedrock"
requires:
- pnpm-monorepo
- depcheck:
Expand Down
2 changes: 0 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
# Packages
/packages/chain-mon @ethereum-optimism/security-reviewers
/packages/chain-mon/internal/balance-mon @ethereum-optimism/infra-reviewers
/packages/common-ts @ethereum-optimism/typescript-reviewers
/packages/contracts-bedrock @ethereum-optimism/contract-reviewers
/packages/core-utils @ethereum-optimism/legacy-reviewers
/packages/sdk @ethereum-optimism/devxpod

# Bedrock codebases
Expand Down
43 changes: 0 additions & 43 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,48 +221,13 @@ pull_request_rules:
label:
add:
- A-pkg-chain-mon
- name: Add A-pkg-common-ts label and ecopod reviewers
conditions:
- 'files~=^packages/common-ts/'
- '#label<5'
actions:
label:
add:
- A-pkg-common-ts
request_reviews:
users:
- roninjin10
- name: Add A-pkg-contracts-bedrock label
conditions:
- 'files~=^packages/contracts-bedrock/'
actions:
label:
add:
- A-pkg-contracts-bedrock
- name: Add A-pkg-contracts-ts label
conditions:
- 'files~=^packages/contracts-ts/'
- '#label<5'
actions:
label:
add:
- A-pkg-contracts-ts
- name: Add A-pkg-core-utils label
conditions:
- 'files~=^packages/core-utils/'
- '#label<5'
actions:
label:
add:
- A-pkg-core-utils
- name: Add A-pkg-fee-estimation label
conditions:
- 'files~=^packages/fee-estimation/'
- '#label<5'
actions:
label:
add:
- A-pkg-fee-estimation
- name: Add A-pkg-sdk label and ecopod reviewers
conditions:
- 'files~=^packages/sdk/'
Expand All @@ -274,14 +239,6 @@ pull_request_rules:
request_reviews:
users:
- roninjin10
- name: Add A-pkg-web3js-plugin label
conditions:
- 'files~=^packages/web3js-plugin/'
- '#label<5'
actions:
label:
add:
- A-pkg-web3js-plugin
- name: Add A-proxyd label
conditions:
- 'files~=^proxyd/'
Expand Down
14 changes: 1 addition & 13 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,6 @@
"editor.formatOnSave": true
},
"eslint.workingDirectories": [
{
"directory": "packages/core-utils",
"changeProcessCWD": true
},
{
"directory": "packages/common-ts",
"changeProcessCWD": true
},
{
"directory": "packages/contracts",
"changeProcessCWD": true
},
{
"directory": "packages/chain-mon",
"changeProcessCWD": true
Expand All @@ -25,4 +13,4 @@
"eslint.format.enable": true,
"editorconfig.generateAuto": false,
"files.trimTrailingWhitespace": true
}
}
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,8 @@ The Optimism Immunefi program offers up to $2,000,042 for in-scope critical vuln
├── <a href="./ops-bedrock">ops-bedrock</a>: Bedrock devnet work
├── <a href="./packages">packages</a>
│ ├── <a href="./packages/chain-mon">chain-mon</a>: Chain monitoring services
│ ├── <a href="./packages/common-ts">common-ts</a>: Common tools for building apps in TypeScript
│ ├── <a href="./packages/contracts-bedrock">contracts-bedrock</a>: Bedrock smart contracts
│ ├── <a href="./packages/contracts-ts">contracts-ts</a>: ABI and Address constants
│ ├── <a href="./packages/core-utils">core-utils</a>: Low-level utilities that make building Optimism easier
│ ├── <a href="./packages/fee-estimation">fee-estimation</a>: Tools for estimating gas on OP chains
│ ├── <a href="./packages/sdk">sdk</a>: provides a set of tools for interacting with Optimism
│ └── <a href="./packages/web3js-plugin">web3js-plugin</a>: Adds functions to estimate L1 and L2 gas
├── <a href="./proxyd">proxyd</a>: Configurable RPC request router and proxy
├── <a href="./specs">specs</a>: Specs of the rollup starting at the Bedrock upgrade
└── <a href="./ufm-test-services">ufm-test-services</a>: Runs a set of tasks to generate metrics
Expand Down
2 changes: 0 additions & 2 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ flag_management:
- type: patch
target: 100%
- name: bedrock-go-tests
- name: common-ts-tests
- name: contracts-tests
- name: core-utils-tests
- name: chain-mon-tests
- name: sdk-tests
12 changes: 0 additions & 12 deletions packages/common-ts/.depcheckrc

This file was deleted.

3 changes: 0 additions & 3 deletions packages/common-ts/.eslintrc.js

This file was deleted.

2 changes: 0 additions & 2 deletions packages/common-ts/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions packages/common-ts/.lintstagedrc.yml

This file was deleted.

3 changes: 0 additions & 3 deletions packages/common-ts/.prettierrc.js

This file was deleted.

Loading

0 comments on commit 07d7010

Please sign in to comment.