feat(batch-submitter): Ensure empty batches are not submitted

ethereum-optimism · Oct 14, 2021 · 948a530 · 948a530
1 parent 04b220c
commit 948a530
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/.changeset/honest-lizards-change.md b/.changeset/honest-lizards-change.md
@@ -0,0 +1,5 @@
+---
+'@eth-optimism/batch-submitter': patch
+---
+
+Ensure empty batches are not submitted
diff --git a/ops/envs/batches.env b/ops/envs/batches.env
@@ -3,7 +3,7 @@ ADDRESS_MANAGER_ADDRESS=
 DEBUG=info*,error*,warn*,debug*
 
 MAX_L1_TX_SIZE=90000
-MIN_L1_TX_SIZE=0
+MIN_L1_TX_SIZE=32
 MAX_TX_BATCH_COUNT=50
 MAX_STATE_BATCH_COUNT=50
 

diff --git a/packages/batch-submitter/.env.example b/packages/batch-submitter/.env.example
@@ -16,7 +16,7 @@ L1_NODE_WEB3_URL=http://localhost:9545
 L2_NODE_WEB3_URL=http://localhost:8545
 
 MAX_L1_TX_SIZE=90000
-MIN_L1_TX_SIZE=0
+MIN_L1_TX_SIZE=32
 MAX_TX_BATCH_SIZE=50
 MAX_STATE_BATCH_COUNT=2000
 MAX_TX_BATCH_COUNT=250

diff --git a/packages/batch-submitter/src/exec/run-batch-submitter.ts b/packages/batch-submitter/src/exec/run-batch-submitter.ts
@@ -334,6 +334,11 @@ export const run = async () => {
     }
   }
 
+  if (requiredEnvVars.MIN_L1_TX_SIZE === 0) {
+    logger.error('Must configure a MIN_L1_TX_SIZE greater than 0')
+    process.exit(1)
+  }
+
   const clearPendingTxs = requiredEnvVars.CLEAR_PENDING_TXS
 
   const l2Provider = injectL2Context(