New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(op-node): handle async disconnects to avoid test flakiness #10019
Conversation
WalkthroughWalkthroughThe recent update introduces a retry mechanism to the peer disconnection process in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ran this test with -count
of 1000 and it didn't fail once.
Description
This change implements a simple retry strategy for p2p disconnect in tests. The disconnect operation is async and we need to verify the peer was correctly released, so we check few times with an increasing delay to avoid test flakiness.
Part of https://github.com/ethereum-optimism/devinfra-pod/issues/38