feat(ctb): Subgame rez changes

[clabby]

Overview

Changes subgame resolution to track in-order resolution and re-use the clock logic from move to reduce duplication.

Metadata
closes https://github.com/ethereum-optimism/client-pod/issues/727

[clabby]

• feat(ctb): Relax re-proving constraints in OptimismPortal2 #10154
• chore(ctb): Add test for LibClone improvement #10153
• fix(ctb): LibGameType downcast fix #10152
• chore(ctb): Remove payable from resolveClaim #10151
• fix(ctb): LibPosition downcasting #10150
• feat(ctb): Pass msg.sender to dispute games from the factory #10149
• feat(ctb): Subgame rez changes #10148 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite

[coderabbitai]

Walkthrough

Walkthrough

The recent updates aim to improve dispute resolution mechanisms within the Bedrock contracts. These changes refine subgame resolution logic, manage challenger durations, and optimize bond distribution. Unit tests now feature enhanced timing logic to accurately simulate diverse game scenarios, ensuring the robustness of the game logic.

Changes

Files	Change Summary
.../FaultDisputeGame.sol	Added internal mapping for resolved subgames, updated semantic version constant, adjusted clock duration calculations, and modified subgame resolution.
.../FaultDisputeGame.t.sol	Adjusted timing logic in unit tests for resolving claims by modifying time calculations to simulate different game scenarios accurately.

---

Recent Review Details

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between 34ce96a and 4492e46.

Files ignored due to path filters (7)

• op-bindings/bindings/faultdisputegame.go is excluded by !op-bindings/bindings/**
• op-bindings/bindings/faultdisputegame_more.go is excluded by !op-bindings/bindings/**
• packages/contracts-bedrock/semver-lock.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/FaultDisputeGame.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/PermissionedDisputeGame.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/storageLayout/FaultDisputeGame.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/storageLayout/PermissionedDisputeGame.json is excluded by !**/*.json

Files selected for processing (2)

• packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol (10 hunks)
• packages/contracts-bedrock/test/dispute/FaultDisputeGame.t.sol (19 hunks)

Files skipped from review as they are similar to previous changes (2)

• packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
• packages/contracts-bedrock/test/dispute/FaultDisputeGame.t.sol

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[refcell]

Everything looks consistent ✅

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (34ce96a) to head (d650e7b).

❗ Current head d650e7b differs from pull request most recent head 4492e46. Consider uploading reports for the commit 4492e46 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10148       +/-   ##
============================================
- Coverage    42.40%   29.22%   -13.18%     
============================================
  Files           73       31       -42     
  Lines         4830     2898     -1932     
  Branches       766      614      -152     
============================================
- Hits          2048      847     -1201     
+ Misses        2676     1976      -700     
+ Partials       106       75       -31     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

[Inphi]

Excellent!