Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ctb): LibGameType downcast fix #10152

Merged
merged 2 commits into from Apr 17, 2024
Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Apr 15, 2024

Overview

Corrects the unchecked downcast in LibGameType from a uint8 -> uint32 (GameType's underlying primitive)

Metadata
closes https://github.com/ethereum-optimism/client-pod/issues/733

Copy link

semgrep-app bot commented Apr 15, 2024

Semgrep found 2 sol-style-notice-over-dev-natspec findings:

  • packages/contracts-bedrock/src/dispute/interfaces/IDisputeGame.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from aab0f74 to b8726c3 Compare April 15, 2024 15:17
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from fb6eca5 to ff35518 Compare April 15, 2024 15:17
@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from b8726c3 to 0d9153f Compare April 15, 2024 18:06
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from ff35518 to b0b5f09 Compare April 15, 2024 18:06
@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from 0d9153f to 8dc4aa8 Compare April 15, 2024 18:08
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from b0b5f09 to 8b9cfe0 Compare April 15, 2024 18:08
@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from 8dc4aa8 to e411fa2 Compare April 15, 2024 19:39
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from 8b9cfe0 to ffc7e71 Compare April 15, 2024 19:39
@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from e411fa2 to f416308 Compare April 15, 2024 20:31
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from ffc7e71 to 975d985 Compare April 15, 2024 20:31
@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from f416308 to 7fb29a8 Compare April 15, 2024 22:41
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from 975d985 to b51d458 Compare April 15, 2024 22:41
@clabby clabby force-pushed the cl/ctb/remove-payable-resolve-claim branch from 7fb29a8 to 6f496db Compare April 15, 2024 23:13
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from b51d458 to a01702f Compare April 15, 2024 23:13
Base automatically changed from cl/ctb/remove-payable-resolve-claim to develop April 16, 2024 01:26
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from a01702f to 6f1f58a Compare April 16, 2024 02:21
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@refcell refcell added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@refcell refcell added this pull request to the merge queue Apr 16, 2024
@clabby clabby removed this pull request from the merge queue due to a manual request Apr 16, 2024
@clabby clabby added the M-do-not-merge Meta: Do not merge label Apr 16, 2024
@clabby
Copy link
Member Author

clabby commented Apr 16, 2024

Merge #10163 first pls

@clabby clabby added this pull request to the merge queue Apr 16, 2024
@clabby clabby removed this pull request from the merge queue due to a manual request Apr 16, 2024
@clabby clabby force-pushed the cl/ctb/lib-game-type-cast-fix branch from 6f1f58a to b3d0ecf Compare April 16, 2024 20:15
@clabby clabby enabled auto-merge April 16, 2024 20:15
@clabby clabby removed the M-do-not-merge Meta: Do not merge label Apr 16, 2024
@clabby clabby added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@clabby clabby added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@Inphi Inphi added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@clabby clabby added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 46977a7 Apr 17, 2024
75 checks passed
@clabby clabby deleted the cl/ctb/lib-game-type-cast-fix branch April 17, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants