New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ctb): LibGameType
downcast fix
#10152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Semgrep found 2 Prefer |
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 15:17
aab0f74
to
b8726c3
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 15:17
fb6eca5
to
ff35518
Compare
refcell
approved these changes
Apr 15, 2024
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 18:06
b8726c3
to
0d9153f
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 18:06
ff35518
to
b0b5f09
Compare
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 18:08
0d9153f
to
8dc4aa8
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 18:08
b0b5f09
to
8b9cfe0
Compare
smartcontracts
approved these changes
Apr 15, 2024
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 19:39
8dc4aa8
to
e411fa2
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 19:39
8b9cfe0
to
ffc7e71
Compare
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 20:31
e411fa2
to
f416308
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 20:31
ffc7e71
to
975d985
Compare
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 22:41
f416308
to
7fb29a8
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 22:41
975d985
to
b51d458
Compare
clabby
force-pushed
the
cl/ctb/remove-payable-resolve-claim
branch
from
April 15, 2024 23:13
7fb29a8
to
6f496db
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 15, 2024 23:13
b51d458
to
a01702f
Compare
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 16, 2024 02:21
a01702f
to
6f1f58a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 16, 2024
Merge #10163 first pls |
clabby
force-pushed
the
cl/ctb/lib-game-type-cast-fix
branch
from
April 16, 2024 20:15
6f1f58a
to
b3d0ecf
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 16, 2024
This was referenced Apr 17, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Corrects the unchecked downcast in
LibGameType
from auint8
->uint32
(GameType
's underlying primitive)Metadata
closes https://github.com/ethereum-optimism/client-pod/issues/733