Plasma: Abstract CommitmentData to Interface #10458
Conversation
This is a generic commitment to be used by the op-node & op-batcher.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
|
Semgrep found 1 Service 'op_stack_go_builder' is running with a writable root filesystem. This may allow malicious applications to download and run additional payloads, or modify container files. If an application inside a container has to save something temporarily consider using a tmpfs. Add 'read_only: true' to this service to prevent this. Ignore this finding from writable-filesystem-service.Semgrep found 1 Service 'op_stack_go_builder' allows for privilege escalation via setuid or setgid binaries. Add 'no-new-privileges:true' in 'security_opt' to prevent this. Ignore this finding from no-new-privileges. |
axelKingsley
force-pushed
the
axel/useGenericComm
branch
from
d9b70b2
to
c89f6ed
Compare
axelKingsley
force-pushed
the
axel/useGenericComm
branch
from
c89f6ed
to
25cf8f2
Compare
axelKingsley
force-pushed
the
axel/useGenericComm
branch
from
473643f
to
ba3c0cd
Compare
axelKingsley
requested review from
protolambda,
ajsutton and
a team
as code owners
WalkthroughWalkthroughThe recent updates across various files involve transitioning from using Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
axelKingsley
force-pushed
the
axel/useGenericComm
branch
from
906f8da
to
28f1c5a
Compare
* op-node: Generic Commitment This is a generic commitment to be used by the op-node & op-batcher. * abstract commitments to CommitmentData interface * correct byte-stripping ; add tests ; finish wiring * make GenericCommitment always verify * correct action tests * PR comments * fix unit test * remove fmt.Println --------- Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
What
Abstracts Keccak and Generic Commitment types to a
CommitmentData, and wires it throughout the projectWhy
op-nodemust support different modes of operation for Generic and Keccak commitments, which are signaled by a type byte at the front of the data.How
Now, in all places where a commitment is decoded, the package function
DecodeCommitmentDatais used. This handles the type check, does some basic validation, and then calls down to the implementation-specific decoder.And, in all places where a commitment is encoded,
NewCommitmentDatais used. This function takes theCommitmentTypeto decide which concrete type to use.The
CommitmentDatainterface replaces all reference to concrete types in existing Plasma/DA behaviors.Outside of these activities, all access to the
CommitmentDatahappens through interface-defined functions which Keccak and Generic already supported --Encode, Verify, TxDataOmitting
Not featured in this PR is any feature-flagging from the node for the expected Commitment Type. @trianglesphere has a plan in mind to group the config details, so that will be wired in then. The DA Client similarly is set to only produce Keccak commitments.
Testing
Tests were written for the CommitmentData interface to confirm it creates the right type of commitment and handles errors as expected.
DA server tests are fixed to type-assert Keccak type Commitments, as the server components are designed to only use those. When flags are wired into the
NextandSetInputfunctions, the test can be multiplied by both Commitment Types. The Mock DA Server is already set to handle that with this PR, you can just overload the Commitment Type the mock uses.