-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/interop: add tests for L1BlockInterop
#10571
feat/interop: add tests for L1BlockInterop
#10571
Conversation
Warning Rate Limit Exceeded@0xfuturistic has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 31 minutes and 48 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes across the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Semgrep found 4
Named return arguments to functions must be appended with an underscore ( Semgrep found 3 No Semgrep found 1 Detected a network listener listening on 0.0.0.0 or an empty string. This could unexpectedly expose the server publicly as it binds to all available interfaces. Instead, specify another IP address that is not 0.0.0.0 nor the empty string. Ignore this finding from avoid-bind-to-all-interfaces.Semgrep found 1 Please create a GitHub ticket for this TODO. Ignore this finding from todos_require_linear.Semgrep found 1 superfluous nil err check before return Ignore this finding from err-nil-check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
5928c95
to
e9de97c
Compare
L1BlockInterop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
packages/contracts-bedrock/src/L2/L1BlockInterop.sol (1)
Line range hint
37-37
: Consider adding more detailed error messages for reverts to enhance debugging and user feedback.- revert NotDepositor(); + revert NotDepositor("Only the depositor account can call this function.");
c607d7c
to
2f697f4
Compare
ac5518a
to
fe2565e
Compare
2f697f4
to
c5e598f
Compare
fe2565e
to
ce193bd
Compare
c5e598f
to
a087731
Compare
ce193bd
to
6d21eb2
Compare
Semgrep found 3 Named return arguments to functions must be appended with an underscore ( |
d98560b
to
675edba
Compare
bf0f0cf
to
1dc2e61
Compare
675edba
to
379d971
Compare
1dc2e61
to
08d0088
Compare
379d971
to
337a90f
Compare
abb356b
to
5bc1ab2
Compare
337a90f
to
9d4eb16
Compare
4c4cb5d
to
06a3a27
Compare
2750c93
to
23a0917
Compare
06a3a27
to
57c45d0
Compare
23a0917
to
85a16b9
Compare
57c45d0
to
e4a6f81
Compare
e4a6f81
to
4dae15a
Compare
85a16b9
to
1e61b68
Compare
a2a1765
into
feat/interop-L1BlockInterop
add tests for
L1BlockInterop
in https://github.com/ethereum-optimism/optimism/tree/feat/separate-dynamic-L1Attributes