ctb: Add removeDeployerFromSafe method to deploy scripts

[maurelian]

Adds a new removeDeployerFromSafe() method, to be used with the keepDeployer option on the deploySafe() method.

[maurelian]

• ctb: Add removeDeployerFromSafe method to deploy scripts #10620 👈
• ctb: Add Guardian Safe to ownership deployment #10616
• ctb: Break out Safe deployment from configuration #10615
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maurelian and the rest of your teammates on Graphite

[semgrep-app]

Semgrep found 1 todos_require_linear finding:

• packages/core-utils/src/common/bn.ts
  • L17 - Triage

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

[coderabbitai]

Walkthrough

Walkthrough

The updates encompass modifications to the deployment and configuration scripts for contracts. They introduce new functionalities for managing ownership and security, including the addition of the OwnerManager import, new functions for removing deployers, renaming and restructuring configuration structs, and adding new deployment and configuration functions for Guardian Safe. Additionally, tests have been updated with new helper functions and assertions to ensure the correct configuration and ownership properties.

Changes

File Path	Change Summary
.../contracts-bedrock/scripts/Deploy.s.sol	Added OwnerManager import, introduced removeDeployerFromSafe function, and updated comments for clarity in the Deploy contract.
.../contracts-bedrock/scripts/DeployOwnership.s.sol	Renamed SecurityCouncilConfig to GuardianConfig, adjusted related configurations, and added functions for deploying and configuring the Guardian Safe.
.../contracts-bedrock/test/Safe/DeployOwnership.t.sol	Added GuardianConfig import, new helper functions for Safe config assertions, and tests for Foundation, Security Council, and Guardian Safe configurations. Added checks to ensure msg.sender is not an owner of the safe.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b917499 and 29ef7cf.

Files selected for processing (1)

• packages/contracts-bedrock/test/Safe/DeployOwnership.t.sol (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/contracts-bedrock/test/Safe/DeployOwnership.t.sol

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.26%. Comparing base (df2aeba) to head (29ef7cf).
Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10620       +/-   ##
============================================
- Coverage    55.13%   39.26%   -15.88%     
============================================
  Files           37       27       -10     
  Lines         2900     1821     -1079     
  Branches       415      415               
============================================
- Hits          1599      715      -884     
+ Misses        1269     1106      -163     
+ Partials        32        0       -32     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

[semgrep-app]

Semgrep found 2 invalid-usage-of-modified-variable findings:

• op-conductor/conductor/service.go
  • L668-678 - Triage
  • L668-678 - Triage

Variable unsafeInNode is likely modified and later used on error. In some cases this could result in panics due to a nil dereference

_{Ignore this finding from invalid-usage-of-modified-variable.}