op-challenger: Include bonds when listing claims

[ajsutton]

Description

Shows the bond paid for each claim in list-claims subcommand.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes across various files in the project involve improvements to handling claim information and balance conversions. Import statements have been added for bigint and eth, enhancing functionality and ensuring accurate data representation in the op-challenger and op-service components.

Changes

Files	Change Summary
op-challenger/cmd/list_claims.go	Added imports for bigint and eth, updated listClaims to display both Bond and Bond (ETH) values.
op-service/client/mocks/HTTP.go	Added a newline at the end of the file.
op-service/eth/balance.go	Introduced WeiToEther function for converting wei to ether as a float64.
op-service/eth/balance_test.go	Renamed package from metrics to eth, updated function name to WeiToEther.
op-service/metrics/balance.go	Removed weiToEther function, adjusted import statements.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1da9f66 and 3702d48.

Files selected for processing (5)

• op-challenger/cmd/list_claims.go (3 hunks)
• op-service/client/mocks/HTTP.go (1 hunks)
• op-service/eth/balance.go (1 hunks)
• op-service/eth/balance_test.go (2 hunks)
• op-service/metrics/balance.go (3 hunks)

Files skipped from review due to trivial changes (1)

• op-service/client/mocks/HTTP.go

Files skipped from review as they are similar to previous changes (1)

• op-challenger/cmd/list_claims.go

Additional comments not posted (1)

op-service/eth/balance_test.go (1)

34-34: The tests for WeiToEther are comprehensive and well-structured.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

op-service/eth/balance.go (1)

9-16: The implementation of WeiToEther looks correct and well-documented.

Consider adding error handling or a check for the result of Float64() to handle potential floating-point conversion issues.

op-service/metrics/balance.go (1)

Line range hint 15-35: The integration of WeiToEther in LaunchBalanceMetrics is correctly implemented.

Consider adding more detailed logging at different stages of the balance retrieval process for better traceability.