Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pnpm min version #10629

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented May 23, 2024

The current minimal version of pnpm is 9. (source)

It seems the minimal version for foundry also needs to update, using 0.2.0 (a5efe4f) will meet this error:

foundry config error: Unknown variant transient-storage for setting `ignored_error_codes.0`

But I didn't find the exact min version.(only this)

@zhiqiangxu zhiqiangxu requested a review from a team as a code owner May 23, 2024 12:31
@zhiqiangxu zhiqiangxu requested a review from tynes May 23, 2024 12:31
Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

Walkthrough

The update involves modifying a script that displays the versions of various dependencies. Specifically, the version of pnpm has been upgraded from 8 to 9. This change ensures that the script reflects the latest version of pnpm, aligning with any updated dependencies or improvements in the package manager.

Changes

File Path Change Summary
packages/.../scripts/getting-started/versions.sh Updated pnpm version from 8 to 9 in the echo statement.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 46a9f00 and 2dc9bb0.
Files selected for processing (1)
  • packages/contracts-bedrock/scripts/getting-started/versions.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/contracts-bedrock/scripts/getting-started/versions.sh

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tynes tynes added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@tynes tynes added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@tynes tynes added this pull request to the merge queue May 23, 2024
Merged via the queue into ethereum-optimism:develop with commit 2b3f00d May 23, 2024
66 checks passed
tarunkhasnavis pushed a commit that referenced this pull request May 28, 2024
rdovgan pushed a commit to rdovgan/optimism that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants