contracts-bedrock: sequencer-enforced invariants #10791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/l2 message validation
feat: buffer gas constraints on l2 message validation thresholds
feat: Handle message validation gas
sam-iamm
changed the title
|
Definitely not including this in the OP Stack. It adds way too much complexity into the bridge |
|
I appreciate you opening this PR, definitely recommend doing a design doc first to get buy in before doing any implementation to save time. Left some comments on ethereum-optimism/design-docs#30 |
tynes
reviewed
Jun 11, 2024
| RELAY_RESERVED_GAS + RELAY_GAS_CHECK_BUFFER | ||
| + _relayMessageValidatorGas(messageValidator, uint64(_message.length)) | ||
| ) || xDomainMsgSender != Constants.DEFAULT_L2_SENDER | ||
| || !_isRelayMessageValidated(messageValidator, _nonce, _sender, _target, _value, _message) |
There was a problem hiding this comment.
This part of the diff is particularly not great to have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the (optional) L1 -> L2 message validation hooks solution to enable sequencer-enforced invariants.
Sequencer-enforced invariants design doc: ethereum-optimism/design-docs#30
Tests
To-do - will add tests if the design is approved.