Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): prevent L2->L1 calls to system contracts #1183

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

maurelian
Copy link
Contributor

Description

A small change to the L1 Messenger, which prevents an L2 to L1 call from send calling the CTC.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2021

🦋 Changeset detected

Latest commit: 28fe31e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tynes
Copy link
Contributor

tynes commented Jun 28, 2021

I've confirmed that the mainnet artifact is as expected. This will need to follow up with a yarn generate-markdown to create the deployments/README.md with the updated address

ben-chain
ben-chain previously approved these changes Jun 28, 2021
Copy link
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

smartcontracts
smartcontracts previously approved these changes Jun 28, 2021
@maurelian maurelian dismissed stale reviews from smartcontracts and ben-chain via 5ea95bb June 28, 2021 20:04
@maurelian maurelian force-pushed the patch/prevent-enqueue-from-l2-r2 branch from 3dad92d to 5ea95bb Compare June 28, 2021 20:04
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to run yarn generate-markdown to create the packages/contracts/README.md

@maurelian maurelian force-pushed the patch/prevent-enqueue-from-l2-r2 branch from 5ea95bb to df46d6c Compare June 28, 2021 23:40
@maurelian maurelian force-pushed the patch/prevent-enqueue-from-l2-r2 branch from df46d6c to f59fa09 Compare June 29, 2021 13:49
@maurelian
Copy link
Contributor Author

Still needs to run yarn generate-markdown to create the packages/contracts/README.md

Done. This change only affected the impl addresses, which only affects an html comment, so the tables themselves were unaffected.

@maurelian maurelian force-pushed the patch/prevent-enqueue-from-l2-r2 branch from f59fa09 to 28fe31e Compare June 29, 2021 19:02
@maurelian maurelian requested a review from tynes June 29, 2021 19:02
- 0xa172330C2E6Ec2bF04662Bb9b67ae857910b7f7f
- https://kovan.etherscan.io/address/0xa172330C2E6Ec2bF04662Bb9b67ae857910b7f7f)
- 0x333d2674E2D7e1e7327dc076030ce9615183709C
- https://kovan.etherscan.io/address/0x333d2674E2D7e1e7327dc076030ce9615183709C)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running yarn generate-markdown the only changes were in these comments, because the only deployed changes are to implementation contracts.

@tynes tynes merged commit 21e47e1 into develop Jun 29, 2021
@tynes tynes deleted the patch/prevent-enqueue-from-l2-r2 branch June 29, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants