-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(contracts): prevent L2->L1 calls to system contracts #1183
Conversation
🦋 Changeset detectedLatest commit: 28fe31e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I've confirmed that the mainnet artifact is as expected. This will need to follow up with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
3dad92d
to
5ea95bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs to run yarn generate-markdown
to create the packages/contracts/README.md
5ea95bb
to
df46d6c
Compare
df46d6c
to
f59fa09
Compare
Done. This change only affected the impl addresses, which only affects an html comment, so the tables themselves were unaffected. |
f59fa09
to
28fe31e
Compare
- 0xa172330C2E6Ec2bF04662Bb9b67ae857910b7f7f | ||
- https://kovan.etherscan.io/address/0xa172330C2E6Ec2bF04662Bb9b67ae857910b7f7f) | ||
- 0x333d2674E2D7e1e7327dc076030ce9615183709C | ||
- https://kovan.etherscan.io/address/0x333d2674E2D7e1e7327dc076030ce9615183709C) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After running yarn generate-markdown
the only changes were in these comments, because the only deployed changes are to implementation contracts.
Description
A small change to the L1 Messenger, which prevents an L2 to L1 call from send calling the CTC.