Add tests for convertInternalLogsToOvmLogs #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: * Add a seperate function for getting ovm transaction metadata * Move CallingWithEOA into the EOA function and add an argument
…m/TestEventParsing
willmeister
approved these changes
Feb 21, 2020
packages/ovm/package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "scripts": { | |||
| "all": "yarn clean && yarn build && yarn test && yarn fix && yarn lint", | |||
| "test:govm": "waffle waffle-config.json && mocha --require source-map-support/register --require ts-node/register 'test/govm/*.spec.ts' --timeout 60000 --exit", | |||
| "test": "waffle waffle-config.json && mocha --require source-map-support/register --require ts-node/register 'test/contracts/*.spec.ts' --timeout 8000 --exit", | |||
| "test": "waffle waffle-config.json && mocha --require source-map-support/register --require ts-node/register 'test/contracts/*.spec.ts' 'test/app/*.spec.ts' --timeout 8000 --exit", | |||
There was a problem hiding this comment.
Can we use test/**/*.spec.ts instead of writing both out?
There was a problem hiding this comment.
Unfortunately we can't match on everything in test because that would match test/govm which we want to run separately with test:govm. We might be able to remove govm tests in a separate PR if we decide to table govm for the time being.
I did at least combine app and contracts into one though 👍
| @@ -41,7 +41,9 @@ contract ExecutionManager is FullStateManager { | |||
| address _codeContractAddress, | |||
| bytes32 _codeContractHash | |||
| ); | |||
| event CallingWithEOA(); | |||
| event CallingWithEOA( | |||
| address _ovmFromAddress | |||
gakonst
added a commit
that referenced
this pull request
Apr 12, 2021
* pkg: import l2geth * chore: add l2geth tests submodule * ci: unit test l2geth * chore: skip Android tests * chore: cleanup ci
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* fix jumpi inputs ordering * fix comment
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* pkg: import l2geth * chore: add l2geth tests submodule * ci: unit test l2geth * chore: skip Android tests * chore: cleanup ci
Merged
keroro520
added a commit
to keroro520/optimism
that referenced
this pull request
May 18, 2023
…-stopped feat: add API admin_sequencerStopped
keroro520
pushed a commit
to keroro520/optimism
that referenced
this pull request
Oct 20, 2023
* op-batcher: Add metrics for pending L2 transaction data size (ethereum-optimism#5797) * feat(op-node): Finalize Mainnet Rollup Config [release branch] (ethereum-optimism#5905) * copy over develop chainsgo * stage rollup config changes * final rollup config values * fix(op-batcher): solve race condition of BatchSubmitter publishTxToL1 and handleReceipt access state concurrently (#5) * chore: update readme, add testnet assets (ethereum-optimism#9) * chore: update readme, add testnet assets * doc: clarify readme * ci: add the ci code used to package and release docker images (ethereum-optimism#11) * ci: add the ci code used to package and release docker images (#7) * ci: add the ci code used to package and release docker images Co-authored-by: Welkin <welkin.b@nodereal.com> * fix: add latest tag for docker image (ethereum-optimism#9) Co-authored-by: Welkin <welkin.b@nodereal.com> * try to use cache for docker build (ethereum-optimism#10) Co-authored-by: Welkin <welkin.b@nodereal.com> --------- Co-authored-by: Welkin <welkin.b@nodereal.com> * feat(ci): add ci workflow * fix * fix * update * update * skip fail test temporarily * add batcher/proposer * add e2e * skip fail e2e case temporary * add op-node-lint * fix lint * add batcher/proposer lint * test junit-report * add junit report for all * adjust parallel to 2 for avoiding fail * add needs for job serial execution * use testname format to simplify result --------- Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: refcell.eth <abigger87@gmail.com> Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com> Co-authored-by: Owen <owen.h@nodereal.io> Co-authored-by: Welkin <welkin.b@nodereal.com>
therealbytes
added a commit
to therealbytes/optimism
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
CallingWithEOAevent into theCallEOAfunction and add an argument to simplify event parsingMetadata
Fixes
Contributing Agreement