Deleted update functions, getSingleNodeRootHash internal functions, a…

[Michael-Vander-Meiden]

Description
packages/contracts/contracts/libraries/trie/Lib_MerkleTrie.sol:

• deleted update function
• deleted getSingleNodeRootHash internal function

packages/contracts/contracts/libraries/trie/Lib_SecureMerkleTrie.sol:

• deleted update function
• deleted getSingleNodeRootHash internal function

packages/contracts/test/contracts/libraries/trie/Lib_MerkleTrie.spec.ts

• deleted test for update function

packages/contracts/test/contracts/libraries/trie/Lib_SecureMerkleTrie.spec.ts

• deleted test for update function
• deleted test for getSingleNodeRootHash internal function

Metadata

• Fixes Delete update code from Lib_MerkleTrie #2377

[changeset-bot]

🦋 Changeset detected

Latest commit: 1867a4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@eth-optimism/contracts	Patch
@eth-optimism/data-transport-layer	Patch
@eth-optimism/sdk	Patch
@eth-optimism/message-relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tynes]

Can you add a changeset for the contracts package and squash into a single commit? Thanks!

[Michael-Vander-Meiden]

Sure thing, will do that now

[Michael-Vander-Meiden]

@tynes done!

[tynes]

Thanks for updating @Michael-Vander-Meiden! I apologize and should have mentioned that this should be a patch changeset. Pre 1.0.0 we aren't following semver exactly, do you mind updating this? Then it will be good to go

[Michael-Vander-Meiden]

Thanks for updating @Michael-Vander-Meiden! I apologize and should have mentioned that this should be a patch changeset. Pre 1.0.0 we aren't following semver exactly, do you mind updating this? Then it will be good to go

Sorry I just saw this. Third time's the charm! Switched it to patch. 😁

[tynes]

cc @maurelian

[maurelian]

This is safe to merge once the checks are running, but it would be preferable to also delete _getUpdatedTrieRoot().
If we can get that in quickly, great. But I'll approve regardless.

[mslipper]

Hi Michael!

To get builds running please unfollow your fork of optimism and follow the repo under our organization. CircleCI uses which repo you follow to determine which repo to build. More details from CircleCI's documentation:

Note: If a user submits a pull request to your repository from a fork, but no pipeline is triggered, then the user most likely is following a project fork on their personal account rather than the project itself of CircleCi, causing the jobs to trigger under the user’s personal account and not the organization account. To resolve this issue, have the user unfollow their fork of the project on CircleCI and instead follow the source project. This will trigger their jobs to run under the organization when they submit pull requests.

[maurelian]

Ugh, sorry for the trouble @Michael-Vander-Meiden, but you'll need to rebase this on develop, and run yarn lint to fix that failed check.

Thanks for working through this with us.

[Michael-Vander-Meiden]

No worries, working on it now.

[Michael-Vander-Meiden]

hey @maurelian , just want to make sure I get this right. When you say rebase on develop, do you mean pull develop into my iss2377 branch and then lint, or something else?

edit
feeling kind of dumb for the question but I should just go to my branch, git rebase develop and thats that?

[maurelian]

git pull --rebase origin develop should be the command you need. The important thing is that your changes are made on top of the latest commit on our develop.

[Michael-Vander-Meiden]

Hey @maurelian ! There ended up being a lot more unused functions than I originally thought. I deleted those as well some more tests and fixed the linting issues.

If things still look good to you then I will go ahead and squash these commits to prep for merge.

[maurelian]

Nothing like the smell of deleted code in the morning!These changes look great, squash away.

[Michael-Vander-Meiden]

@maurelian looks ready for merge!😁

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.