Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix foundry config to use profiles key #3088

Merged
merged 1 commit into from Jul 26, 2022
Merged

Conversation

maurelian
Copy link
Contributor

Addresses this warning:

Unknown section [default] found in foundry.toml. This notation for profiles has been deprecated and may result in the profile not being registered in future versions. Please use [profile.default] instead or run `forge config --fix`.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

⚠️ No Changeset found

Latest commit: 32b41a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-op-bindings Area: op-bindings labels Jul 25, 2022
@tynes
Copy link
Contributor

tynes commented Jul 25, 2022

We can update the version of foundry in the ci-builder docker image which should fix the broken yarn-monorepo build

@maurelian
Copy link
Contributor Author

We can update the version of foundry in the ci-builder docker image which should fix the broken yarn-monorepo build

Just to whatever is latest?

@tynes
Copy link
Contributor

tynes commented Jul 25, 2022

Just released a new ci-builder image, potentially will unblock, otherwise will need to release a foundry image then another ci-builder

@tynes
Copy link
Contributor

tynes commented Jul 26, 2022

We should open a new PR that fixes the bindings build

Address this warning: Unknown section [default] found in foundry.toml. This notation for profiles has been deprecated and may result in the profile not being registered in future versions. Please use [profile.default] instead or run .
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 0d9769b into develop Jul 26, 2022
@mergify mergify bot deleted the m/fix-foundry-config branch July 26, 2022 17:43
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 26, 2022
maurelian added a commit that referenced this pull request Jul 26, 2022
Address this warning: Unknown section [default] found in foundry.toml. This notation for profiles has been deprecated and may result in the profile not being registered in future versions. Please use [profile.default] instead or run .
@mslipper mslipper mentioned this pull request Aug 4, 2022
maurelian added a commit that referenced this pull request Sep 15, 2022
Address this warning: Unknown section [default] found in foundry.toml. This notation for profiles has been deprecated and may result in the profile not being registered in future versions. Please use [profile.default] instead or run .
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
Address this warning: Unknown section [default] found in foundry.toml. This notation for profiles has been deprecated and may result in the profile not being registered in future versions. Please use [profile.default] instead or run .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-bindings Area: op-bindings A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants