contracts-bedrock: standard initializable #3109
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only 1 initializable instead of two different initializable
imports. Using contracts with the same name will break hardhat.
The two different initializable imports were:
```solidity
import { Initializable } from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
```
```solidity
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
```
This standardizes on not using `contracts-upgradeable`.
🦋 Changeset detectedLatest commit: 6196d97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
mslipper
approved these changes
Jul 27, 2022
protolambda
approved these changes
Jul 27, 2022
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
tynes
added a commit
that referenced
this pull request
Jul 27, 2022
Use only 1 initializable instead of two different initializable
imports. Using contracts with the same name will break hardhat.
The two different initializable imports were:
```solidity
import { Initializable } from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
```
```solidity
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
```
This standardizes on not using `contracts-upgradeable`.
Merged
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
Use only 1 initializable instead of two different initializable
imports. Using contracts with the same name will break hardhat.
The two different initializable imports were:
```solidity
import { Initializable } from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
```
```solidity
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
```
This standardizes on not using `contracts-upgradeable`.
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
Use only 1 initializable instead of two different initializable
imports. Using contracts with the same name will break hardhat.
The two different initializable imports were:
```solidity
import { Initializable } from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
```
```solidity
import { Initializable } from "@openzeppelin/contracts/proxy/utils/Initializable.sol";
```
This standardizes on not using `contracts-upgradeable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use only 1 initializable instead of two different initializable
imports. Using contracts with the same name will break hardhat.
The two different initializable imports were:
This standardizes on not using
contracts-upgradeable.