contracts-bedrock: L2ToL1MessagePasser event extension #3135
+251
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e272fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
|
I guess you need this here rather than the fixes repo because of the SDK? |
maurelian
reviewed
Jul 29, 2022
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
7f23f19
to
55e195f
Compare
|
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
Emit an additional event during `initiateWithdrawal` that includes the withdrawal hash so that it is easy to observe changes to the `sentMessages` mapping.
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
55e195f
to
97e7345
Compare
tynes
commented
Aug 1, 2022
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
97e7345
to
5eb0f6f
Compare
protolambda
requested changes
Aug 1, 2022
trianglesphere
approved these changes
Aug 1, 2022
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
e805294
to
6e272fc
Compare
protolambda
approved these changes
Aug 1, 2022
|
Not sure why the e2e tests hang when running in the cloud, they work fine locally edit: nvm seems like a flake or something, they worked now |
|
This PR has been added to the merge queue, and will be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emit an additional event during
initiateWithdrawalthat includesthe withdrawal hash so that it is easy to observe changes to the
sentMessagesmapping.