New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts-bedrock: add forge contract verification support #3141
Conversation
🦋 Changeset detectedLatest commit: 903d205 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future.
8c1e014
to
903d205
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
* contracts-bedrock: add forge contract verification support Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future. * contracts-bedrock: modularize tasks
* contracts-bedrock: add forge contract verification support Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future. * contracts-bedrock: modularize tasks
* contracts-bedrock: add forge contract verification support Add etherscan contract verification for the hh/foundry compiler toolchain. This will eventually be upstreamed, but is implemented here to ensure that it works thoroughly first. To run the task: ``` export ETHERSCAN_API_KEY=$(cat api-key.txt) $ npx hardhat forge-verify --network goerli ``` In the future, other contract verification backends will be added to forge and this task will be updated to support them. Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code An individual contract can be targeted instead of all of them with the `--contract` flag. If hardhat deploy has configured external deployments, forge will not be able to verify them. It may be possible to implement that in the future. * contracts-bedrock: modularize tasks
Description
Add etherscan contract verification for the hh/foundry
compiler toolchain. This will eventually be upstreamed,
but is implemented here to ensure that it works thoroughly
first.
To run the task:
In the future, other contract verification backends
will be added to forge and this task will be updated
to support them.
Example contract that was verified: https://goerli.etherscan.io/address/0x1234662682c85fa6fb375416d14db965eba222ba#code
An individual contract can be targeted instead of all of them
with the
--contract
flag. If hardhat deploy has configuredexternal deployments, forge will not be able to verify them.
It may be possible to implement that in the future.