Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contracts-bedrock: Fix provider usage in L2OutputOracle deployment script #3148

Merged
merged 3 commits into from Aug 1, 2022
Merged

contracts-bedrock: Fix provider usage in L2OutputOracle deployment script #3148

merged 3 commits into from Aug 1, 2022

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Aug 1, 2022 •
edited

getDefaultProvider() returns a fallback mainnet provider, which doesn't work.

Builds on #3147.

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022 •
edited

⚠️ No Changeset found

Latest commit: 09efcf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Aug 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/hh-deploy-fix-provider branch from 7e2a715 to 4c7bd2a Compare August 1, 2022 03:53
@mslipper
contracts-bedrock: Fix provider usage in L2OutputOracle deployment sc…
7aca4c5 
…ript

`getDefaultProvider()` returns a fallback mainnet provider, which doesn't work.

Builds on #3147.
@mslipper mslipper force-pushed the feat/hh-deploy-fix-provider branch from 4c7bd2a to 7aca4c5 Compare August 1, 2022 03:53
@mslipper mslipper changed the title contracts-bedrock: Fix hardhat deploy provider contracts-bedrock: Fix provider usage in L2OutputOracle deployment script Aug 1, 2022
@mslipper mslipper merged commit 6d9011e into develop Aug 1, 2022
@mslipper mslipper deleted the feat/hh-deploy-fix-provider branch August 1, 2022 05:27
@mslipper mslipper mentioned this pull request Aug 4, 2022
Merged
maurelian pushed a commit that referenced this pull request Sep 15, 2022
@mslipper @maurelian
contracts-bedrock: Fix provider usage in L2OutputOracle deployment sc…
5f0abb9 
…ript (#3148)

* ci: Tag cloudbuild images with the commit SHA

* contracts-bedrock: Fix provider usage in L2OutputOracle deployment script

`getDefaultProvider()` returns a fallback mainnet provider, which doesn't work.

Builds on #3147.
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
@mslipper @sam-goldman
contracts-bedrock: Fix provider usage in L2OutputOracle deployment sc…
5204c50 
…ript (#3148)

* ci: Tag cloudbuild images with the commit SHA

* contracts-bedrock: Fix provider usage in L2OutputOracle deployment script

`getDefaultProvider()` returns a fallback mainnet provider, which doesn't work.

Builds on #3147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@trianglesphere trianglesphere Awaiting requested review from trianglesphere

Assignees
No one assigned
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mslipper @tynes