Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Derivation metrics #3156

Merged
merged 2 commits into from Aug 3, 2022
Merged

op-node: Derivation metrics #3156

merged 2 commits into from Aug 3, 2022

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Aug 2, 2022

Adds support for the following batch derivation metrics:

  • 0/1 gauge for if the derivation is idle
  • Count of total pipeline resets
  • Count of total unsafe payloads received
  • Count of total derivation errors
  • Gauge tracking the various L1/L2 safe/unsafe heads

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

⚠️ No Changeset found

Latest commit: 8f14ab0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Adds support for the following batch derivation metrics:

- 0/1 gauge for if the derivation is idle
- Count of total pipeline resets
- Count of total unsafe payloads received
- Count of total derivation errors
- Gauge tracking the various L1/L2 safe/unsafe heads
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some nits on application of metrics in driver event loop, then good to merge.

op-node/rollup/driver/state.go Outdated Show resolved Hide resolved
op-node/rollup/driver/state.go Show resolved Hide resolved
@mslipper mslipper merged commit a184269 into develop Aug 3, 2022
@mslipper mslipper deleted the feat/derivation-metrics branch August 3, 2022 07:03
@mslipper mslipper mentioned this pull request Aug 4, 2022
roninjin10 pushed a commit that referenced this pull request Aug 26, 2022
* op-node: Derivation metrics

Adds support for the following batch derivation metrics:

- 0/1 gauge for if the derivation is idle
- Count of total pipeline resets
- Count of total unsafe payloads received
- Count of total derivation errors
- Gauge tracking the various L1/L2 safe/unsafe heads

* review updates + more metrics
maurelian pushed a commit that referenced this pull request Sep 15, 2022
* op-node: Derivation metrics

Adds support for the following batch derivation metrics:

- 0/1 gauge for if the derivation is idle
- Count of total pipeline resets
- Count of total unsafe payloads received
- Count of total derivation errors
- Gauge tracking the various L1/L2 safe/unsafe heads

* review updates + more metrics
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* op-node: Derivation metrics

Adds support for the following batch derivation metrics:

- 0/1 gauge for if the derivation is idle
- Count of total pipeline resets
- Count of total unsafe payloads received
- Count of total derivation errors
- Gauge tracking the various L1/L2 safe/unsafe heads

* review updates + more metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants