Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxyd: Add frontend rate limiting #3166

Merged
merged 2 commits into from Aug 4, 2022
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Aug 3, 2022

To give us more flexibiltiy with rate limiting, proxyd now supports rate limiting of client (frontend) requests in addition to upstream (backend) requests. This PR also gives us the ability to exempt certain user agents/origins from rate limiting.

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2022

🦋 Changeset detected

Latest commit: c75060d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/proxyd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/proxyd-custom-rate-limit branch 2 times, most recently from e339ba5 to c403dab Compare August 3, 2022 22:48
@mslipper mslipper requested review from Inphi and tynes August 3, 2022 22:48
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proxyd/backend.go Outdated Show resolved Hide resolved
To give us more flexibiltiy with rate limiting, proxyd now supports rate limiting of client (frontend) requests in addition to upstream (backend) requests. This PR also gives us the ability to exempt certain user agents/origins from rate limiting.
@mslipper mslipper force-pushed the feat/proxyd-custom-rate-limit branch from 1f82a86 to c75060d Compare August 4, 2022 17:27
@Inphi
Copy link
Contributor

Inphi commented Aug 4, 2022

yup clone is good. LGTM!

@mslipper mslipper merged commit b6f4bfc into develop Aug 4, 2022
@mslipper mslipper deleted the feat/proxyd-custom-rate-limit branch August 4, 2022 17:34
@mslipper mslipper mentioned this pull request Aug 4, 2022
roninjin10 pushed a commit that referenced this pull request Aug 26, 2022
* proxyd: Add frontend rate limiting

To give us more flexibiltiy with rate limiting, proxyd now supports rate limiting of client (frontend) requests in addition to upstream (backend) requests. This PR also gives us the ability to exempt certain user agents/origins from rate limiting.

* lint
maurelian pushed a commit that referenced this pull request Sep 15, 2022
* proxyd: Add frontend rate limiting

To give us more flexibiltiy with rate limiting, proxyd now supports rate limiting of client (frontend) requests in addition to upstream (backend) requests. This PR also gives us the ability to exempt certain user agents/origins from rate limiting.

* lint
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* proxyd: Add frontend rate limiting

To give us more flexibiltiy with rate limiting, proxyd now supports rate limiting of client (frontend) requests in addition to upstream (backend) requests. This PR also gives us the ability to exempt certain user agents/origins from rate limiting.

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants