Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ctb): no refunds #3535

Merged
merged 4 commits into from
Sep 27, 2022
Merged

feat(ctb): no refunds #3535

merged 4 commits into from
Sep 27, 2022

Conversation

smartcontracts
Copy link
Contributor

Description
Removes refunds from the StandardBridge flow.

Tests
Removes tests related to refund logic.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022 •
edited

🦋 Changeset detected

Latest commit: fb3327c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/contracts-bedrock Minor
@eth-optimism/actor-tests Patch
@eth-optimism/sdk Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Sep 23, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-no-refunds branch 4 times, most recently from 700c392 to 8a96412 Compare September 23, 2022 03:20
@smartcontracts smartcontracts force-pushed the sc/ctb-no-refunds branch 4 times, most recently from 4086f51 to ff75e3a Compare September 23, 2022 03:24
@tynes
Copy link
Contributor

tynes commented Sep 23, 2022

Needs a regenerated snapshot

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 23, 2022
@smartcontracts smartcontracts marked this pull request as ready for review September 23, 2022 17:34
@mergify mergify bot removed the conflict label Sep 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 23, 2022
@mergify mergify bot removed the conflict label Sep 24, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 23.32% // Head: 23.53% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (32f3a77) compared to base (220ad4e).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3535      +/-   ##
===========================================
+ Coverage    23.32%   23.53%   +0.21%     
===========================================
  Files          335      335              
  Lines        33993    33672     -321     
  Branches       136      133       -3     
===========================================
- Hits          7929     7926       -3     
+ Misses       25125    24806     -319     
- Partials       939      940       +1
Impacted Files Coverage Δ
op-bindings/bindings/deployerwhitelist_more.go 60.00% <ø> (ø)
op-bindings/bindings/gaspriceoracle_more.go 60.00% <ø> (ø)
op-bindings/bindings/governancetoken_more.go 60.00% <ø> (ø)
...p-bindings/bindings/l1crossdomainmessenger_more.go 60.00% <ø> (ø)
op-bindings/bindings/l1standardbridge.go 2.65% <ø> (+0.26%) ⬆️
...p-bindings/bindings/l2crossdomainmessenger_more.go 60.00% <ø> (ø)
op-bindings/bindings/l2standardbridge.go 0.52% <ø> (+0.11%) ⬆️
op-bindings/bindings/l2standardbridge_more.go 60.00% <ø> (ø)
op-bindings/bindings/l2tol1messagepasser_more.go 60.00% <ø> (ø)
op-bindings/bindings/legacyerc20eth_more.go 60.00% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

maurelian
maurelian approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 26, 2022
@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

This is going to need a rebase, will review afterwards

@tynes tynes mentioned this pull request Sep 27, 2022
Merged
@smartcontracts
feat(ctb): no refunds
d71922d 
Removes refunds from the StandardBridge flow.
@mergify mergify bot removed the conflict label Sep 27, 2022
@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

Will need a follow up PR that removes this functionality from the NFT bridge

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 27, 2022
@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

Looks like another PR was merged, needs another rebase

@mslipper
Copy link
Collaborator

I'll take care of it

@mergify mergify bot removed the conflict label Sep 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 3d4e852 into develop Sep 27, 2022
@mergify mergify bot deleted the sc/ctb-no-refunds branch September 27, 2022 18:37
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 27, 2022
This was referenced Sep 29, 2022
Merged
Merged
@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
@zhiqiangxu
Copy link
Contributor

What's the rationale behind the decision to remove refunds out of the bridge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

Assignees
No one assigned
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smartcontracts @tynes @codecov-commenter @mslipper @zhiqiangxu @maurelian